bnzk / django-painless-redirects Goto Github PK

• from and to in same column, two lines.
• to no more editable

mySQL and indexes, my friend

probably when many requests are made, the code is not threadsafe. enforcing db integrity with unique_together could be the solution.

https://stackoverflow.com/a/22095136/1029469

use fieldsets for less used options, group things, better labels.

with a default of False, so the db is not filled up with tons of variations of GET variables.

throws exception

/products/whatever/it-is/ => /shop/whatever/it-is/

• from url: /products/
• to url: /products/
• wildcard mode: true
• move tree mode: true
• go

• from url opens change view
• "check url" opens from/to url

instead of a middleware. much less load on the db.

needs proof of concept that it really can work (urls reload, multi-server setups, threading, etc).

can crash inserting malware urls, with very long query strings....

Read about it, decide.

possibilities may be: a function, a string (.php), a regex (.*.cfm)

when changing slugs in django-cms, django-filer or django-folderless (planned for now).

can cause:

MultipleObjectsReturned at /
get() returned more than one RedirectHit -- it returned 2!

=> caused by concurrent hits from same referrer, so, not a multi site issue

at least PAINLESS_REDIRECTS_OLD_PATH_MAX_LENGTH!

• enabled
• ignored (!)
• 301/302?
• to path?

directly calling process_response on the middleware is easy, but does not apply as it works in reality.

do redirect if we have a real hit, but do never auto create redirects when url does not start with a language slug (ie /de/ or /en/ or /en-us/ - must be in LANGUAGES, though). as the middleware will redirect to /lang/original-404-maybe/ anyway, and we will fetch it then!

Redirect, and keep GET vars. Must be set on redirect. Decide about this: Normal behaviour is, forget about GET vars when evaluating redirects?!?

/a/b/?x=y --> /c/d/?x=y
/a/b/?z=v --> /c/d/?z=v

with only one entry in the database.

301 as default, 302 selectable

...as in django-advanced-redirects

also, count different referrers.

https://docs.djangoproject.com/en/1.10/topics/http/middleware/#upgrading-middleware

please.

ManualRedirectMiddleware should be above for example LocaleMiddleware (that does the / > /en/ thing), so no false auto created Redirects are made.

want to redirect /foo AND /foo/ (obviously) to /bar/

whne LocaleMiddleware is enabled, together with i18n_patterns in urls.py, we'll have to enter two redirects, with and without slash - as /foo/ is not a valid url (as checked in CommonMiddleware, about here: https://github.com/django/django/blob/main/django/middleware/common.py#L71 ), and because of that, no redirect to /foo/ is made (but, instead, to /language/foo/).

One approach could be to check for Redirects with and without slash at the end, when there is no slash at the end of the current path. Or even try a "ignore the slash at the end" approach, making the final slah irrellevant. This would enhance usability for redirect editors, as currently, one is often forced to enter redirects with and withouth the trailing slahsh.

to prevent redirect caching of modern browsers. if possible, open in a new incognito window, circumventing django-cms overlay issues.

/my-redirect/?check=vnisorvus8zasdoa

(1406, "Data too long for column 'old_path' at row 1")

validate the model before save. zack.

maybe baby