bluemirrors / vidsz Goto Github PK

I think there might be a problem on closing the video reader. This is the situation:

from vidsz.opencv import Reader

reader = Reader("static/countdown.mp4")

while reader.is_open():
    ...
    if condition:
        reader.release()

Since reader.release() does the following:

def release(self) -> None:
    """Release Resources
    """
    if self._video_stream is not None:
        self._video_stream.release()
        self._video_stream = None

on the following iteration, reader is None and thus does not have a function isOpened().
Thus it raises the error: 'NoneType' object has no attribute 'isOpened'.

I tried to check the code if there could be a better way of closing the Reader but I couldn't find one.

What about adding a condition to reader.is_open(), checking that reader._video_stream is not None and ...?