bluejumper / build-onie Goto Github PK

Hello @bluejumper -

I think what you have done is really great. Various folks have wanted this for a long time, but no one ever stood up and made it happen. Honestly, thanks a bunch for doing this.

I have a couple of suggestions, however.

First off I think we should move this into the ONIE repo proper. We have a top level contrib sub-directory which could house this code nicely. Longer term I think it will be easier to maintain this code if it lives alongside the main ONIE code base. Also the ONIE documentation could more easily refer to this code.

My other suggestions are in the nature of polish, minor things really. For example instead of having the big apt-get install ... happen when the docker image is created, I would move that step to the instructions and just have the end user run make debian-prepare-build-host. The list of packages needed on the build host does change a little of over time, so relying on make debian-prepare-build-host will prevent us from having to maintain two separate, but nearly identical lists of packages. Anyway that is just a polishing suggestion.

If you are agreeable to me relocating your code let me know. I can make the ONIE pull requests and update various ONIE wiki documentation. I know your LICENSE terms already allow me to do this, but I'd like to include your input first.

Cheers,
Curt