blockchyp / blockchyp-csharp Goto Github PK

Not necessary at all, but it might be nice to have a sort of BlockChypException that is thrown when an endpoint such as charge or preauth timeout. Right now you will get an HttpRequestException but it feels a bit clunky to have to understand what the BlockChypClient is utilizing under-the-hood in order to effectively handle this exception. I imagine that, visually, it'd be a bit more intuitive to catch a sort of BlockChypException to handle a timeout.

It seems that TerminalRouteCache could perhaps benefit from composing with or inheriting from .NET's System.Runtime.Caching.MemoryCache. For C#/.NET devs this might expose a more familiar interface.

It's also worth looking at the source code for MemoryCache's internal MemoryCacheStore. I'm not sure whether it's worth reimplementing much of this functionality when it seems that you'd just like to expand upon it (e.g. utilizing a cache located on the filesystem).

But perhaps I'm missing the bigger picture and, for some reason, MemoryCache isn't a good fit?

Thoughts?