blackjacx / source Goto Github PK

Hey there, so far you always call reloadData on the table view when the datasource gets updated. It would be more efficient/elegant/pretty to do the diffing first and then insert/delete the items that changed. Pre iOS 13 that is, after that it's just a one liner, but either way reloadData ain't ideal. ^^

Expected behaviour

Remove from adjustCellSeparatorInsets(...):

        // explicitly setting cell's layout margins
        directionalLayoutMargins = insets

to be able to properly use directionalLayoutMargins ✌️

Make sure to use this one again in TableContainer instead of updateCellSeparatorInsets()

Actual behaviour

directionalLayoutMargins are not usable since they are influenced by this setting on the UITableViewCell.

Expected behaviour

It must be possible to update the view models without reloading the table view. When you use a e.g. UISwitch and press it the change must be reflected in the view model but since the switch value has already changed it is not necessary to update reload the cell.

Actual behaviour

On update of view models the table is always reloaded.

Make this hot shit work:

• https://wwdcbysundell.com/2019/diffable-data-sources-first-look/
• https://www.swiftmentor.io/blog/exploring-ios-14-building-lists-the-modern-way

Enable Mudule Stability by setting BUILD_LIBRARY_FOR_DISTRIBUTION to YES and SKIP_INSTALL to NO for release builds. See https://www.donnywals.com/what-is-module-stability-in-swift-and-why-should-you-care/

Then you can use a version of the framework compiled using Swift 5.1+ in every app compiled with Swift 5.1+ without recompiling the framework with that specific Swift version.

• optional public func tableView(_ tableView: UITableView, canMoveRowAt indexPath: IndexPath) -> Bool
• optional public func tableView(_ tableView: UITableView, commit editingStyle: UITableViewCellEditingStyle, forRowAt indexPath: IndexPath)
• optional public func tableView(_ tableView: UITableView, moveRowAt sourceIndexPath: IndexPath, to destinationIndexPath: IndexPath)