bkorda / node-red-contrib-zway Goto Github PK

Using complex passwords does not work with this node package.
Example of password(fully functional in Z-way admin page): tV5"uP5(wI8$qB3#zE4"eZ3+fS6"sQ7%

** Hardware / Software **
  - raspberry 3 model b rev 1.2

• version of zway firmware version: 3.1.1
• zway UI version: 1.11
    - version of node-red-contrib-zway: 0.2.3

** Describe issue **
Hi, Making good use of your nodes for node-red to zway, however..
Now I suddenly get "ECONNRESET" errors in node-red from time to time and it seems like zway server cannot keep up.
Do you know if there is some kind of limit I'm hitting maybe ? I have around 137 z-wave nodes and quite some flows in node-red.

Thanks for your help.

Greetings,

Vincent.

Hi,

Just upgraded to zway 3.2.0 and the node is no longer working correctly.
Data is sent out from node-red to Zway, no problems there but,
No data is received from Zway to node-red node anymore.
Can you investigate ?

After selecting Thermostat option in node "In" Node-red is crashing with following error message

19 Feb 22:33:07 - [red] Uncaught Exception:
19 Feb 22:33:07 - ReferenceError: payload is not defined
at zWayItemIn.formatHomeKit (C:\Users\user.node-red\node_modules\node-red-contrib-zway\nodes\in.js:169:37)
at zWayItemIn.sendStateHomekitOnly (C:\Users\user.node-red\node_modules\node-red-contrib-zway\nodes\in.js:132:22)
at Timeout._onTimeout (C:\Users\user.node-red\node_modules\node-red-contrib-zway\nodes\in.js:45:34)
at listOnTimeout (internal/timers.js:554:17)
at processTimers (internal/timers.js:497:7)

The same behaviour on Linux inside docker and outside docker as well.

Problem is that instead of "characteristic" codeword "payload" is used, please update. I will try to prepare pull request with fix

the readings of volt amper and watt values do not come with innode. Instead one must create a get node and read it regularly, for example 1/s. It would be preferable to be able to get those values through the in node.

• strings: "rrr,bbb,ggg", "(rrr,bbb,ggg)", "RGB(rrr,bbb,ggg)" , e.g. "210,100,100" - Error: Element is not a number
• array of strings: "rrr","bbb","ggg", or array of value rrr,bbb,ggg - Not change on device, TypeError: payload.split is not a function
• objects format identical as I get from device: RGB {r: rrr, b: bbb, g: ggg}, color {r: rrr, b: bbb, g: ggg} - Not change on device

I have no more ideas.

PS. No problem with sending value to other class the same device, e.g Dimmer 1.

Great nodes! Really like!

In NodeRed topic is often used to keep track of devcices, in all inject nodes for example topic can be set. It would be great if I could set the topic in the nodes or that it lets the topic property of msg pass through the node. Now it deletes the topic property.

Regards

I'm using a Nodon Soft remote. The 4 buttons work and the messages are transferred to the Node-Red node, but only the first press of a button. So if I click button 1 and after a while I click button 1 again the second click is not visible in my debug window. If I however click another button the node sends the corresponding message. If I look at my Zway screen I can see the time of the last click being updated in the elements window, so the Zwave signal does arrive at the Zway controller, but the node doesn't do anything. Also if I double click or hold the previous button the node reacts to the first instance of this event, but not a second time.

I'm using the State output of the node, not the homekit.

** Hardware / Software **
  - raspberry 4  

• version of zway firmware version: [v3.0.4]
• zway UI version: [1.10.2]
    - version of node-red-contrib-zway: [0.2.2]

** Describe issue **
Hi, much like the issue I raised on node-red-contrib-zigbee2mqtt, this repo also has an old version of "multiple-select" embedded in the static/ folder that breaks the new monaco editor (See here)

The issue is (i believe) specific to multiple-select V1.4.2 and below - see this issue: wenzhixin/multiple-select#483

Could you please update to V1.5.2 as it does not cause the editor to break.

** Screens / Logs **

Hi,

I see my docker container with node-red crashes sometimes.
I think it is caused by the zway module, and most likely, when a device is not reachable.
Here is the error from docker container, if you need more info, just let me know:

extractfromerrorlog.txt

** Describe issue **
crashes with "TypeError: Cannot read property 'title' of undefined" on last +1 element of list

** Your flow here **

[
    {
        "id": "5a74f90a824af681",
        "type": "zway-output",
        "z": "0dac92a75b2f75fc",
        "name": "",
        "server": "5b24a085ec576130",
        "device": {
            "length": 0,
            "prevObject": {
                "length": 0,
                "prevObject": {
                    "0": {
                        "location": {
                            "ancestorOrigins": {},
                            "href": "http://192.168.4.105:1880/#flow/0dac92a75b2f75fc",
                            "origin": "http://192.168.4.105:1880",
                            "protocol": "http:",
                            "host": "192.168.4.105:1880",
                            "hostname": "192.168.4.105",
                            "port": "1880",
                            "pathname": "/",
                            "search": "",
                            "hash": "#flow/0dac92a75b2f75fc"
                        },
                        "jQuery35103621877289210641": {
                            "events": {
                                "mouseup": [
                                    {
                                        "type": "mouseup",
                                        "origType": "mouseup",
                                        "guid": 3,
                                        "namespace": ""
                                    }
                                ],
                                "click": [
                                    {
                                        "type": "click",
                                        "origType": "click",
                                        "data": null,
                                        "guid": 4246,
                                        "namespace": ""
                                    },
                                    {
                                        "type": "click",
                                        "origType": "click",
                                        "data": null,
                                        "guid": 4259,
                                        "namespace": ""
                                    },
                                    {
                                        "type": "click",
                                        "origType": "click",
                                        "data": null,
                                        "guid": 4499,
                                        "namespace": ""
                                    }
                                ]
                            },
                            "focusin": 3
                        }
                    },
                    "length": 1
                }
            }
        },
        "device_name": "",
        "command": "on",
        "commandType": "zway_cmd",
        "payload": "payload",
        "payloadType": "msg",
        "x": 520,
        "y": 260,
        "wires": []
    },
    {
        "id": "5b24a085ec576130",
        "type": "zway-server",
        "name": "Zway-server",
        "ip": "192.168.4.105",
        "port": "80",
        "authToken": "_____________________________________"
    }
]

** Screens / Logs **

26 Oct 11:39:01 - [info] [zway-server:Zway-server] discoverDevices: Using cached devices
TypeError: Cannot read property 'title' of undefined
    at /home/pi/.node-red/node_modules/node-red-contrib-zway/nodes/server.js:126:53
    at ServerNode.discoverDevices (/home/pi/.node-red/node_modules/node-red-contrib-zway/nodes/server.js:92:17)
    at ServerNode.getItemsList (/home/pi/.node-red/node_modules/node-red-contrib-zway/nodes/server.js:120:18)
    at /home/pi/.node-red/node_modules/node-red-contrib-zway/zway.js:25:24
    at Layer.handle [as handle_request] (/usr/lib/node_modules/node-red/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/lib/node_modules/node-red/node_modules/express/lib/router/route.js:144:13)
    at Route.dispatch (/usr/lib/node_modules/node-red/node_modules/express/lib/router/route.js:114:3)
    at Layer.handle [as handle_request] (/usr/lib/node_modules/node-red/node_modules/express/lib/router/layer.js:95:5)
    at /usr/lib/node_modules/node-red/node_modules/express/lib/router/index.js:284:15
    at Function.process_params (/usr/lib/node_modules/node-red/node_modules/express/lib/router/index.js:346:12)

I have checked the response from ZWay, and it contains a list of devices. They all have a metrics object including a title prop. I added some console.log statements, and it turns out that the for .. in construct seems to add an extra element, where the last element is a function! I also tried replacing with a plain for loop, and then that extra object is not included.

There are diffferent locations in server.js that iterates this way. Below is some code and corresponding log output from another part of the code. First, using the for .. in:

And then the plain old for loop:

I also tried a more modern .forEach approach, but then the server.js code seemed to not be executed at all.

** Hardware / Software **

  - raspberry 4  

• version of zway firmware version: [v3.2.3]
• zway UI version: [1.13.5]
• node-red version: [v2.2.2]
    - version of node-red-contrib-zway: [1.0.0]
    - node version: [v14.20.0]