bkoelman / resharpercodecontractnullabilityfxcop Goto Github PK

It appears that some source locations in PDB, which is used as input by FxCop to determine source locations, are wrong in VS2013 Community (observed in RTM and Update 5). As a result, reported symbols by this analyzer highlight the wrong source code line when double-clicked.

A connect bug has been submitted for this.

Repro:

class C
{
    byte[] f;
}

Reports:

Annotate 'f' with [ItemNotNull] or [ItemCanBeNull].

This is incorrect, because the underlying item type, byte in this case, cannot contain null.

Backport latest fixes from https://github.com/bkoelman/ResharperCodeContractNullability and setup MyGet feed

Example:

public class C : ICollection<string>
{
    // ...
    public void CopyTo(string[] array, int arrayIndex) { ... }
}

Reports:

Annotate 'array' with [NotNull] or [CanBeNull].

Which is incorrect, because an external annotation exists for ICollection.CopyTo:

<member name="M:System.Collections.Generic.ICollection`1.CopyTo(`0[],System.Int32)">
    <parameter name="array">
      <attribute ctor="M:JetBrains.Annotations.NotNullAttribute.#ctor" />
    </parameter>
  </member>

Because of this, Resharper grays out the annotation after manually adding it.

Repro:

class C
{
    public int this[string a, string b, string c]
    {
        get { throw new NotImplementedException();}
        set { throw new NotImplementedException();}
    }
}

Expected:
Annotate 'a' with [NotNull] or [CanBeNull].
Annotate 'b' with [NotNull] or [CanBeNull].
Annotate 'c' with [NotNull] or [CanBeNull].

Actual:
Annotate 'Item' with [NotNull] or [CanBeNull].