bjpirt / heatmiser-js Goto Github PK

When I try to run the test program with the following parameters, it crashes with an AssertionError: Trying to read beyond buffer length.

I got the regular Wifi thermostat, so not the timer and not the advanced version

Here is the console output:
node test.js -h 192.168.96.30 -p XXXX

assert.js:102
throw new assert.AssertionError({
^
AssertionError: Trying to read beyond buffer length
at Buffer.readUInt8 (buffer.js:598:12)
at parse_dcb (/home/pi/heatmiser/heatmiser-js/lib/heatmiser.js:28:63)
at parse_response (/home/pi/heatmiser/heatmiser-js/lib/heatmiser.js:87:10)
at Socket.read_device (/home/pi/heatmiser/heatmiser-js/lib/heatmiser.js:99:8)
at Socket.EventEmitter.emit (events.js:96:17)
at TCP.onread (net.js:397:14)

I only figured out that the library keeps crashing after trying to build a ninjablocks (http://ninjablocks.com) driver for my thermostat for 3 hours 😄

Hi @bjpirt thanks so much for your work!

I have stripped the project into components, creating a node package with just the heatmiser sdk, that I'm using for a NinjaBlock module to connect to the thermostats, planning to add write capabilities to change temperature and home/away status
https://github.com/carlossg/heatmiser-node

Would it be possible to have that code under a more permissible license to embed it into other apps with no issues? I typically use ASL but MIT, or LGPL would help.

Thanks!