bjhargrave / transformer-poc Goto Github PK

The transformer can be made to handle renaming all static references, but references to types in a String, which can be assembled at runtime, will need to be handles at runtime.

The tool can mutate the call sites to methods like Class.forName, ClassLoader.loadClass, etc. to call a supplied interceptor method which can inspect the assembled string and perform any renames before calling the method from the original call site.

Package and type names exiting in module-info.class. This metadata should be mutated as necessary for the renamed packages.

The following specs have been moved out of Java SE 8 and will be added in Jakarta EE 9 under the jakarta namespace:

Jakarta Activation (Required)
Jakarta XML Binding (Optional)

https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee9/JakartaEE9ReleasePlan

If the Jar contains OSGi metadata, package and type references in the metadata should be renamed.

OSGi metadata can include the jar manifest as well as other resources like DS component descriptions, etc.

In jakarta-rules.properties we currently have this:

	javax/servlet/jsp/jstl/tlv=jakarta/servlet/jsp/jstl/tlv,\
	javax/servlet/jsp/tagext=jakarta/servlet/jsp/tagext,\
	javax/transaction=jakarta/transaction,\
	javax/validation=jakarta/validation,\
	javax/validation/bootstrap=jakarta/validation/bootstrap,\

I don't have the full details on which classes are involved, but I roughly recall the javax.transaction package is now split as some of the classes ship with the JVM and some do not. Transforming everything at runtime will definitely work as, correct or not, all the code will consistently be changed. But any static change will have to agree with other code that compiled against the valid JVM javax.transaction classes.

@nmcl IIRC you lead the JSR that handled the split, do you happen to have the class list handy?
@bjhargrave does the transformer have the ability to target specific classes of a package, leaving others alone?

The constant pool contains String constants among many other constants. These constants may also need renaming if, for example, they refer to a property name which has been renamed.

So the tool should be extended to defines rules, possibly using REGEX, to support renaming String constants.

JDK 11 introduced NestHost and NestMembers attributes which both hold type names. These attribute need to be mutated if any referenced type is in a renamed package.