bjankord / categorizr

A modern device detection script

Hello

I'm Brett Jankord, a Lead Software Engineer living in the Midwest that enjoys working on Front-End Development, ReactJS/VueJS, Design Systems, Accessibility, Responsive Web Design, CSS, SCSS, NodeJS/ExpressJS, and open source software.

I also like to spend time riding my bike through the woods, grilling food while enjoying a cold drink, and playing video games.

You can find me on Twitter: @bjankord

📈 GitHub Stats

categorizr's Issues

Why mess with sessions at all?

The assumption this script makes is that all sites use PHP's native sessions which isn't true. The script does not need any session code to cache the result.

function categorizr(){
    static $result = NULL;

    if($result) return $result;

    ....
    (run checks here)
    ....

    $result = 'desktop';
    ....

   return $result;
}

Then if someone happens to want the category saved in the session they can just do this:

$_SESSION['category'] = categorizr();

Needs Capabilities

It would be helpful if device classification could include basic capabilities matrix like "touch, speech, gesture, localstorage, canvas, svg" etc similar to DeviceAtlas. A plugin path for this or a method to add to the $device object for these would be helpful. I realize that is waaay out of scope for now, but a path to this would be a tremendous addition.

Repo still active?

Hey,

I'm just wondering is this project still active? There's been no activity on it in the last few months and am wondering how up-to-date the regex are.

Thanks,
Pat

Not reflecting iPad

https://github.com/bjankord/Categorizr/blob/master/categorizr.php#L83

I think this is wrong as it never returns true for iPad. Shouldn't the FOLIO check be negated?

JavaScript Port

Hey @bjankord. I just ported your code to a cross-platform javascript build, though I’ve taken a slightly different approach in some of the API implementation. Check it out and let me know what you think.

https://github.com/iamdustan/categorizr.js