biurad / poakium Goto Github PK

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

The current state of the repository's codebase related to HTTP Galaxy is in need of cleanup and improvement. There are several issues that need to be addressed to enhance the overall quality, readability, and maintainability of the code.

Additionally, the existing coding standards within the HTTP Galaxy repo are not consistent and have to be refactored to improve maintenance in the long run ensuring that the code is well-organized, follows established coding standards, and adheres to Poakium's best practices.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

Improve GitHub Actions Workflow

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

What happened?

If more than one commits is found in my independent repo and support for split, instead of branch pushing to branch, the current checkout branch pushes to all branches.

Expected Behavior or Solution

I expect all branch to contain the expected commits from their parent branches.

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

This library should be lightweight and fast enough to perform batch import/export. It should include a .monorepo config file for advance configuration.

Features to include

• Imported repositories should support re-imports in case a pull-request is created on those individual repositories, it can be merged into monorepo.
• The library should be designed in such a way that is supports either CI or local imports/export.
• Again, the design should support having monorepo as private repository and imports/exports of private repos too.
• The library should be able to be extendable using repo workers.

The goal of this library is to provide a convenient/easier way of using monorepo even with no prior knowledge of git monorepo. This library should work on any kind of repo despite the programming language a repo uses.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

What happened?

When running a concurrent run with a list of commands, even with the parameter $exitOnFailure set to true, I expected the command to fail. Looks like there's some inconsistency in handling commands error.

The error message used for concurrent runs needs to be updated.

Expected Behavior or Solution

Expected run to end when an error is encountered.

Steps To Reproduce

No response

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

What happened?

There's no method in the repository class for knowing how many concurrent runs were executed.

Expected Behavior or Solution

I suggest adding a getConcurrentRuns method. The expected behaviour is to reset for every new run/concurrent run.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

This library should be lightweight and have blazingly fast performance over all most of the database libraries out there. ORM support show be highly optimized to prevent hibernation.

The library's goal is to become the underlying code leveraged for writing PHP projects using databases. For that reason, Prior knowledge of SQL is necessary.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

The current state of the repository's codebase related to caching functionality is in need of cleanup and improvement. There are several issues that need to be addressed to enhance the overall quality, readability, and maintainability of the code.

Additionally, the existing coding standards within the caching repo are not consistent, and has to be refactored to improved maintenance on the long run ensuring that the code is well-organized, follows established coding standards, and adheres to Poakium's best practices.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

A lot of changes has been made to the rade-best branch of the php-di library. Tests have not been written yet and I hope its done in Poakium.

Also the codebase coding standard needs to be changed in Poakium for easier maintainance.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

Every time I run a monorepo command, it re-clones all repositories. I've lots of sub-repositories in my projects do not need to re-clone every single time I run the split command.

Adding a --clean or a shortcut -x to workflow is be recommended if only I need it.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

While going through the code, referencing a recent commit #3a88aae added to the master branch. An error will only occur there if there's a cherry-pick merge conflict.

Instead of returning an error, the code should handle the conflict and continue cherry-picking.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

What happened?

In order not to conflict git history, I suggest support to adding external and full paths be removed. Again, for merging support, can this be fixed to prevent the external/full path issue.

Expected Behavior or Solution

Expects the path config to be required and used in all sub repo config eg:

repoA:
  url: ./../somewhere/repoA
  path: packages/repoA

Steps To Reproduce

No response

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

What happened?

When trying to split all branches using the asterisk as value, an error occurs and expect all branch names without beginning with an asterisk.

Expected Behavior or Solution

No response

Steps To Reproduce

No response

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

What happened?

Cherry picking newly added commits fails if commits is more than one. For instance, 3 commits were added to Poakium. The generated command for cherry picking is: git cherry-pick 'refs/splits/monorepo~2 refs/splits/monorepo~1 refs/splits/monorepo~0'

Expected Behavior or Solution

git cherry-pick refs/splits/monorepo~2 refs/splits/monorepo~1 refs/splits/monorepo~0

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

Importing a bunch of repositories into Poakium

• Annotations
• Cache
• Coding Standard
• Dependency Injection
• Docs
• HTTP Galaxy
• Loader
• Maker
• Security
• Starter
• Templating

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

What happened?

When I run the monorepo split command in GitHub ubuntu-latest CI, it fails as splitsh-lite binary file could not be found. Since the binary exists in repo, I assume a error will never be encountered so no need to for error checking.

Expected Behavior or Solution

The splitsh-lite binary should be able to work as expected

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

The current state of the repository's codebase related to Loader is in need of cleanup and improvement. There are several issues that need to be addressed to enhance the overall quality, readability, and maintainability of the code.

Additionally, the existing coding standards within the Loader repo are not consistent and have to be refactored to improve maintenance in the long run ensuring that the code is well-organized, follows established coding standards, and adheres to Poakium's best practices.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

The current state of the repository's codebase related to templating is in need of cleanup and improvement. There are several issues that need to be addressed to enhance the overall quality, readability, and maintainability of the code.

Additionally, the existing coding standards within the templating repo are not consistent and have to be refactored to improve maintenance in the long run ensuring that the code is well-organized, follows established coding standards, and adheres to Poakium's best practices.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

The current state of the repository's codebase related to Security is in need of cleanup and improvement. There are several issues that need to be addressed to enhance the overall quality, readability, and maintainability of the code.

Additionally, the existing coding standards within the Security repo are not consistent and have to be refactored to improve maintenance in the long run ensuring that the code is well-organized, follows established coding standards, and adheres to Poakium's best practices.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

What happened?

When running the monorepo's split command in windows environment, the error printed in terminal is not what is expected because windows detects the splitsh-lite binary as non-executable.

I recommend this is fixed asap.

Expected Behavior or Solution

Expected error message to begin like: The splitsh-lite command used to split commits to repositories is currently not supported on Windows.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

Loading php files do not work sometimes. Since classes been fetched for loading ain't cached, dependency injections are sometimes used to make it a bit faster to fetching annotations/attributes.

When a class is already fetched or loaded by PHP, requiring the same class file fails or not included at all. I suggest the use of PHP tokenizer to find class names from PHP files.

I again suggest since annotations library was imported as independent into Poakium. The coding standard should change to that of Poakiums'.

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

Well I encountered some issues with the release tags process of using monorepo's workflow split command, I suggest making the process automated with no options at all, it should just work.

My possible solution is to iterate on the commits you want to split and if commit contain's a tag, that tag is splited as well. This is handy and with one command everything should work like magic ✨

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing feature for this?

• I have did my search before proposing a feature request

Proposal or Solution

This library should be a lightweight library for working with git in PHP.

The library's goal is to become the underlying code leveraged for writing PHP projects using git commands. For that reason, Prior knowledge of git commands is necessary.

This should see some performance improvement in writing PHP applications that use git commands over other libraries out there.

Code of Conduct

• I agree to follow this project's Code of Conduct