Support for Uniswap Transactions through Ledger about bittytax

[nanonano]

At the moment there is no support in the conversion tool for Defi transactions, you will have to manually consolidate these.

The plan is to add handling for the most popular Defi apps into the Etherscan parser (you could use this instead of the Ledger Live export), as these exports have more detail, i.e. ContractAddress, to help identify the different Defi apps.

Can't give you a timeline for when this will be available, but a few users have been asking for it, so something I want to add soon.

[nanonano]

Hi @yannickvidal, with this latest change 77362fa. You can use Etherscan to export your transactions/token transactions, and BittyTax will merge the swaps into trades.

[yannickvidal]

Hi @nanonano, that is awesome, thank you for this! I had a go an it seems to merge most transactions.

However, there are some that seem to not get merged. It's not a big deal as they can easily be merged manually, but I thought I would flag it to avoid Withdrawal/Deposit mismatches, so here is an example:

• When trying to bittytax_conv this transaction https://etherscan.io/tx/0x6846540e4278590e48a8da7e0ee3e37bb4b5aacbe6a35c1bafad6da4f5079371 (this is not my wallet, but the issue is exactly the same with mine)
• It generates this BittyTax_Records https://filebin.net/cqfmkq31y35ol4bp. The transaction that happened at 9.27am is in there. However, the second tab has MRPH as a Withdrawal and the third tab ETH as a Deposit. Those two have the same transaction hash and they should, I believe, appear as a Trade instead

Maybe I did not export the CSV from Etherscan properly?

• I went to https://etherscan.io/address/0x2b3406cf0b4fdc68a1bc46553afcf79debc06384
• Downloaded the CSV export for 21 Oct 2021 for the Transactions, Internal Txns and Erc20 Token Txns tabs
• I then ran bittytax_conv ~/Downloads/export-0x2b3406cf0b4fdc68a1bc46553afcf79debc06384.csv ~/Downloads/export-address-token-0x2b3406cf0b4fdc68a1bc46553afcf79debc06384.csv ~/Downloads/'export-0x2b3406cf0b4fdc68a1bc46553afcf79debc06384 (1).csv'

[Kevostos]

Any update on this? There's nothing fancy about 0x6846540e4278590e48a8da7e0ee3e37bb4b5aacbe6a35c1bafad6da4f5079371 - this scenario should be handled correctly.

[nanonano]

It's because the merge parser doesn't consider the internal transactions, this is being worked on.

[Kevostos]

Thank you for the prompt update!

I'm surprised this is not impacting more people as it seems to be an issue with all Swap Exact Token For ETH Uniswap V2 transactions, not simply the ones done through Ledger...

[nubbel]

I've fixed this issue on my own branch: nubbel@29efd69
I'm afraid I don't have time to merge this back upstream as the tax filing deadline is approaching fast and I also made lots of other changes. Feel free to cherry pick or transplant the changes if you find them useful.

[nanonano]

Hi @nubbel, thanks for sharing your changes, I've just pushed a change bf6090d to support NFT and internal txns exports.