Kraken format change about bittytax

[nanonano]

Hi Andy, thanks for raising this, I'll get it fixed asap.

[nanonano]

I've pushed a fix for this, see e3c0aaa. Please install and re-test.

[hodlemperor]

hi, i try the patch and the parse is recognized but after i have errors. This is the result. :

(myenv) root@ubuntugg:~/BittyTax# git branch
* (HEAD detached at origin/master)
  master
(myenv) root@ubuntugg:~/BittyTax# bittytax_conv ../condivisa/example/Ledger-example2.csv -o ../condivisa/BittyTax_Records.xlsx                       file: ../condivisa/example/Ledger-example2.csv matched as "Kraken Ledgers"
output EXCEL file created: ../condivisa/BittyTax_Records.xlsx
(myenv) root@ubuntugg:~/BittyTax# bittytax ../condivisa/BittyTax_Records.xlsx
Excel file: ../condivisa/BittyTax_Records.xlsx
import: 'Kraken L' row[5] ['Withdrawal', '', '', '', '999', 'EUR', '', '-1', 'EUR', '', 'Kraken', '2023-12-06 20:15:50', '']
ERROR Invalid data for Fee Quantity: '-1'
importing 'Kraken L' rows: 100%|███████████████████████████████████████████████████████████████████████████████████| 5/5 [00:00<00:00, 2532.18 row/s]
import failure (success=2, failure=1)

Attached is the obfuscated test file (I changed the id and amounts)

Ledger-example2.csv
thanks

[hodlemperor]

also i try to merge "master" with "margin-trading" and this is the result :

(myenv) root@ubuntugg:~/BittyTax# git branch
* (HEAD detached at origin/testFromMaster)
  master
(myenv) root@ubuntugg:~/BittyTax# bittytax_conv ../condivisa/example/Ledger-example1.csv ../condivisa/example/Ledger-example2.csv -o ../condivisa/BittyTax_Records.xlsx
file: ../condivisa/example/Ledger-example1.csv matched as "Kraken Ledgers"
file: ../condivisa/example/Ledger-example2.csv matched as "Kraken Ledgers"
output EXCEL file created: ../condivisa/BittyTax_Records-2.xlsx
(myenv) root@ubuntugg:~/BittyTax# bittytax ../condivisa/BittyTax_Records-2.xlsx
Excel file: ../condivisa/BittyTax_Records-2.xlsx
import: 'Kraken L' row[5] ['Margin-Fee', '', '', '', '-0.0305', 'EUR', '', '', '', '', 'Kraken', '2016-10-14 10:28:37', '']
ERROR Invalid data for Sell Quantity: '-0.0305'
import: 'Kraken L' row[6] ['Margin-Fee', '', '', '', '-0.0022', 'EUR', '', '', '', '', 'Kraken', '2016-10-14 14:29:37', '']
ERROR Invalid data for Sell Quantity: '-0.0022'
import: 'Kraken L' row[7] ['Margin-Fee', '', '', '', '-0.0022', 'EUR', '', '', '', '', 'Kraken', '2016-10-14 18:30:31', '']
ERROR Invalid data for Sell Quantity: '-0.0022'
import: 'Kraken L' row[8] ['Margin-Fee', '', '', '', '-0.0022', 'EUR', '', '', '', '', 'Kraken', '2016-10-14 22:28:58', '']
ERROR Invalid data for Sell Quantity: '-0.0022'
import: 'Kraken L' row[10] ['Margin-Fee', '', '', '', '-0.0282', 'EUR', '', '', '', '', 'Kraken', '2016-10-15 00:12:34', '']
ERROR Invalid data for Sell Quantity: '-0.0282'
import: 'Kraken L' row[11] ['Withdrawal', '', '', '', '0.9995', 'BTC', '', '-0.0005', 'BTC', '', 'Kraken', '2016-10-15 01:24:18', '']
ERROR Invalid data for Fee Quantity: '-0.0005'
import: 'Kraken L' row[15] ['Withdrawal', '', '', '', '999', 'EUR', '', '-1', 'EUR', '', 'Kraken', '2023-12-06 20:15:50', '']
ERROR Invalid data for Fee Quantity: '-1'
importing 'Kraken L' rows: 100%|█████████████████████████████████████████████████████████████████████████████████| 15/15 [00:00<00:00, 2815.98 row/s]
import failure (success=5, failure=7)

Ledger-example1.csv

And also "adjustment" management is missing from both branch :

file: ../condivisa/ledgers.csv matched as "Kraken Ledgers"
WARNING Parser failure for "Kraken Ledgers"
row[56] ['LSSSSB-BSSSS-6SSSS4', 'LSSSS7A-VSSSK-LSSSSQ', '2019-02-12 16:52:58', 'adjustment', '', 'currency', 'ICN', 'spot / main', '-0.0259325800', '0', '0.0000000000']
ERROR Unrecognised type: 'adjustment'
row[57] ['LSSSSU-USSS5-X5SSSN', 'LSSSSCJ-ZSSSS-DSSSSM', '2019-02-12 16:52:58', 'adjustment', '', 'currency', 'ETH', 'spot / main', '0.0000466786', '0', '7.0000466786']
ERROR Unrecognised type: 'adjustment'
output EXCEL file created: ../condivisa/BittyTax_Records-3.xlsx

NOTE:
"adjustment" = conversion of one currency to another outside of trading (e.g. ICN-to-ETH conversion after ICN delisting).

[nanonano]

Hi @hodlemperor, thanks for this. Looks like Kraken have changed to use negative amounts for fees.

I'll need to patch this and also update the margin-trading branch.

Re: "adjustment", this is new, can you send me an example csv file? Can you confirm the txid and/or refid are not linked for this conversion?

[Roadrunneruk]

Retested and all working fine for new additional heading (wallet)

[hodlemperor]

Hi @hodlemperor, thanks for this. Looks like Kraken have changed to use negative amounts for fees.

I'll need to patch this and also update the margin-trading branch.

Re: "adjustment", this is new, can you send me an example csv file? Can you confirm the txid and/or refid are not linked for this conversion?

Hi, yes txid and/or refid are not linked for both example1 2 and 3
i have only 2 entry examples for adjustment.
Ledger-example3.csv

I attach the file here. (example3)

[nanonano]

I've just pushed a change to the Kraken parser which will handle the negative fees and the new "adjustment' type, see ad39017.

Let me know it's working okay, and then I'll merge it into the margin-trading branch. Thanks!

[hodlemperor]

Hi parse seems to works (bittytax_conv). Problems with "bittytax" command.

(myenv) root@ubuntugg:~/condivisa/example# bittytax_conv Ledger-example1.csv Ledger-example2.csv Ledger-example3.csv
file: Ledger-example1.csv matched as "Kraken Ledgers"
file: Ledger-example2.csv matched as "Kraken Ledgers"
file: Ledger-example3.csv matched as "Kraken Ledgers"
output EXCEL file created: BittyTax_Records.xlsx
(myenv) root@ubuntugg:~/condivisa/example# bittytax BittyTax_Records.xlsx
Excel file: BittyTax_Records.xlsx
import: 'Kraken L' row[5] ['Margin-Fee', '', '', '', '-0.0305', 'EUR', '', '', '', '', 'Kraken', '2016-10-14 10:28:37', '']
ERROR Invalid data for Sell Quantity: '-0.0305'
import: 'Kraken L' row[6] ['Margin-Fee', '', '', '', '-0.0022', 'EUR', '', '', '', '', 'Kraken', '2016-10-14 14:29:37', '']
ERROR Invalid data for Sell Quantity: '-0.0022'
import: 'Kraken L' row[7] ['Margin-Fee', '', '', '', '-0.0022', 'EUR', '', '', '', '', 'Kraken', '2016-10-14 18:30:31', '']
ERROR Invalid data for Sell Quantity: '-0.0022'
import: 'Kraken L' row[8] ['Margin-Fee', '', '', '', '-0.0022', 'EUR', '', '', '', '', 'Kraken', '2016-10-14 22:28:58', '']
ERROR Invalid data for Sell Quantity: '-0.0022'
import: 'Kraken L' row[10] ['Margin-Fee', '', '', '', '-0.0282', 'EUR', '', '', '', '', 'Kraken', '2016-10-15 00:12:34', '']
ERROR Invalid data for Sell Quantity: '-0.0282'
importing 'Kraken L' rows: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 17/17 [00:00<00:00, 2814.08 row/s]
import failure (success=9, failure=5)

[nanonano]

Hi @hodlemperor, I'd only patched the master branch, I've now fixed it in the margin-trading branch also, see 74f6903 and f3fc624. Should all work now, please update and re-test.

[hodlemperor]

sorry for the delay but I didn't have much time.
It seems to work. I'll do more tests

[nanonano]

Ok I'll close this issue for the moment.