Coinbase: Support Convert transaction type about bittytax

[nanonano]

Hi @wayneprice, thanks for raising this. I'll have to update the Coinbase parser to handle this as a Trade transaction type.

[wayneprice]

I have a local fix, which I'm happy to push to a branch.

[nanonano]

I got started on a fix for this, did you do regex to get the sell asset?

I've created a branch https://github.com/BittyTax/BittyTax/tree/fixes/coinbase-parser if you want to push it to there?

[wayneprice]

I did use a regex, yes. I'll see if I can push to that branch

[nanonano]

Nice one, thankyou!

[wayneprice]

Think I might need some permissions to allow me to push?
remote: Permission to BittyTax/BittyTax.git denied to wayneprice.

[nanonano]

I think I should have let you create the branch from your fork and push it.

I've deleted the branch can you add it and try again?

[wayneprice]

It's still not playing ball... do you need to add me as a collaborator or something, maybe?

[nanonano]

I can't even see your fork? Make sure you fork it, then add the branch.

[wayneprice]

Ah. I was trying to push directly to your repo... should be there now

[nanonano]

That's interesting, the pull request merged it into master, I though it would add it as it's own branch.

Thanks again for all your help on this issue, will push a fix for your other issue (#47) shortly, and a couple other things I've noticed which could be improved in the Coinbase parser.

[wayneprice]

I created the pull request as a request to merge to master. Assumed that was the correct thing to do!

[nanonano]

Ah okay, that explains it, no probs.