File format is unrecognised for HitBTC about bittytax

[nanonano]

Finally added a donations button, you can now donate via PayPal to the project. All donations are gratefully received!

[PhilT]

Thanks Scott! Donated! Have a great year!

[nanonano]

Hi @PhilT, it's possible that HitBTC have changed the output format.

Please can you post the first line (headers) of each CVS file here. If you use the -d option when you run it, it will output the header matching.

[PhilT]

Transactions:

header: row[1] TRY: ['Email', 'Date (UTC)', 'Operation id', 'Type', 'Amount', 'Transaction hash', 'Main account balance', 'Currency']

Trades:

header: row[1] TRY: ['Email,Date (UTC),Instrument,Trade ID,Order ID,Side,Quantity,Price,Volume,Fee,Rebate,Total']

Thanks.

[nanonano]

I've created a new branch fixes/issue-26-hitbtc-parser with a fix.

Are you able to test it?

[PhilT]

I just cloned the repo, ran .\setup.py install and then bittytax_conv but get the the same errors.

UPDATE: Forgot to switch branches of course! One sec.

[PhilT]

Nope, same error, even when installing from correct branch.

[nanonano]

Can you do bittytax_conv --help does it show 4 entries for HitBTC like below?

HitBTC
'Email,Date (UTC),Instrument,Trade ID,Order ID,Side,Quantity,Price,Vo...
'Date (UTC),Instrument,Trade ID,Order ID,Side,Quantity,Price,Volume,F...
'Email,Date (UTC),Operation id,Type,Amount,Transaction hash,Main acco...
'Date (UTC),Operation id,Type,Amount,Transaction Hash,Main account ba...

[PhilT]

Ha! Uninstalled pip version then ran install on cloned version. Now showing 4 entries

[PhilT]

Now I get this:

file: ..\..\Downloads\HitBTC-Transactions.csv matched as "HitBTC D,W"
file: ..\..\Downloads\HitBTC-Trades.csv matched as "HitBTC T"
Traceback (most recent call last):
  File "C:\Python27\Scripts\bittytax_conv-script.py", line 11, in <module>
    load_entry_point('BittyTax==0.4.2', 'console_scripts', 'bittytax_conv')()
  File "C:\Python27\lib\site-packages\bittytax-0.4.2-py2.7.egg\bittytax\conv\bittytax_conv.py", line 94, in main
    DataFile.read_csv(filename)
  File "C:\Python27\lib\site-packages\bittytax-0.4.2-py2.7.egg\bittytax\conv\datafile.py", line 129, in read_csv
    data_file = DataFile(cls.FORMAT_CSV, filename, parser, reader)
  File "C:\Python27\lib\site-packages\bittytax-0.4.2-py2.7.egg\bittytax\conv\datafile.py", line 35, in __init__
    data_row.parse(parser, filename)
  File "C:\Python27\lib\site-packages\bittytax-0.4.2-py2.7.egg\bittytax\conv\datarow.py", line 25, in parse
    parser.row_handler(self, parser, filename)
  File "C:\Python27\lib\site-packages\bittytax-0.4.2-py2.7.egg\bittytax\conv\parsers\hitbtc.py", line 32, in parse_hitbtc_trades2
    buy_asset=in_row[2].split('/')[2],
IndexError: list index out of range

[nanonano]

I've just pushed a fix for this, please can you download the branch again.

[PhilT]

No errors this time. But importing into Recap I get negative fee amounts.

[nanonano]

Is the fee amount negative in the generated CSV file or is this what Recap shows?

The fee should be mapped from the original export CSV file without modification, is the fee negative in the export CSV file?

[PhilT]

Yep, some of the fees are negative.

[nanonano]

Just looked at the HitBTC fees, you must have done a lot of trading to get negative fees?! :)

I will have to update the parser to handle this. A GIFT transaction will have to be added for each negative fee in addition to the trade.

[PhilT]

Awesome! Thanks so much for your efforts.

[PhilT]

Don't think I've really done that much. Maybe a bit here and there. Fills do add up though. The amounts were sizable. I've not done 50K Bitcoin though. That cannot be right.

[PhilT]

You do get rebates for providing liquidity though so could be that.

[nanonano]

Can you confirm that if you get a rebate, the matching amount is show as a negative fee, or is the rebate in addition, can you post an example?

[PhilT]

This? https://www.reddit.com/r/CryptoTradingFloor/comments/9pckvm/hitbtc_fees_rebate_system/

[nanonano]

In your trades export file does it have any rebates shown? Are you okay to share an some example row(s) from your file, email me privately if you prefer.

[PhilT]

Hey Scott, Just wanna say a huge thank you for your perseverance with the HitBTC integration. I've finally submitted my tax report to my accountant. It's not perfect but hopefully will be enough. HitBTC don't report pre fork Bitcoin cash transactions so that's another thing to add to their list. They've been in touch a bit with some of the issues but they are very slow so not sure we'll see anything happen this side of Christmas. I'll raise a ticket if they manage to fix any of it. Let me know if there is anything I can do for you? Do you have a tip box or something? Hope you have a good break. Cheers, Phil

…

On Fri, 4 Dec 2020 at 16:44, Scott Green ***@***.***> wrote: Closed #26 <#26>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAIO5Q6VKV5E2OOGY6EKYLSTEGYJANCNFSM4TNB33XQ> .

[nanonano]

Hey @PhilT, glad you got your taxes all sorted, keep me posted if you get any answers from HitBTC.
Thanks for the offer, still need to get a donations address sorted, but please follow BittyTax on Twitter and YouTube and spread the word! Have a great Christmas break too!

[nanonano]

Thanks @PhilT this is the first donation to the project, means a lot to me! Wishing you all the best.