bitcoinjs / bip32-wallet Goto Github PK

This behaviour is often specialized to the implementation.
Enforcing it at this level seems suitable, but odd once you start changing from the defaults.

Instead, it would be better to pull this behaviour up further, and let users decide what to give as unspents to this API.

With age-based priority being disabled by many miners, it is probably also worth ignoring that in selection code as well.

1. Dupe Unspents
   https://github.com/dcousens/bip32-wallet/blob/master/src/wallet.js#L126-L141

I think this might be better to be an object rather than an array to prevent a client error to adding in duplicate unspents or alternatively someway to aid the client to prevent dupes

1. Add unspents

Currently, the API only supports setUnspents. So if there is one new unspent, it has to reset it

The Wallet abstraction is merely another form of BIP32 key management, and probably could be merged with Account and Chain in https://github.com/bitcoinjs/bip32-utils.

It'd be nice to extract the safe-transaction code out to a new module, without giving up the interface simplicity.
It currently makes up the most of this module, and is the most extensively tested.

With the removal of unspents management [in 0.5.0], Wallet is now just a wrapper around a BIP32 Account, with a well tested transaction creation function.

The https://github.com/dcousens/coinselect package extraction was just one part of this.

If anyone else uses this package, I'd be interested to hear your thoughts on this.

Sorry for making this an issue, I wanted to do a PR, but my repo is borked.
I didn't fork properly or something.

Anyways, could you please consider adding something along the following to wallet.js
It is required if one is rebuilding a wallet from a known seed. Super useful to have and I'm not at all sure why it's missing.

Wallet.fromSeedHex = function(hex,network){ var m = bitcoin.HDNode.fromSeedHex(hex, network) var i = m.deriveHardened(0) var external = i.derive(0) var internal = i.derive(1) return new HDWallet.Wallet(external, internal) }

Thanks!

Transactions generated by this software are still identifiable to this software.

The order by address change prevented the users change address being easily identified (it was always originally always the last output, sorting by address changed that).

However, what it did not prevent is the transaction being recognizable as being produced by this software.

To change this, we need to sort the inputs/outputs by some non-deterministic entropy or user secret.

Deprecate this module in favour of https://github.com/bitcoinjs/bip32-utils