bitbagcommerce / syliusadyenplugin_old Goto Github PK

Hello,
There is a small naming error on the ModificationRequestAdyenBridgeInteface file and class => ModificationRequestAdyenBridgeInterface

See you soon.

Hey!

first of all, thank you for this Plugin! 😄

Would you create a new tag? Currently, the latest stable version isn't useable in newer versions of sylius, because all services are private by default.

This commit fixes this issue :)

Many Thanks!

We have concurrent runs, to update a status to 'paid'.

1. customer "checkout callback"
2. Adyen "/payment/adyen/notify"
   Both set the status on paid, and all state-machine-callbacks are running twice.

Did you also experienced this problem?
related: Sylius/Sylius#10872

Hi I am getting this issue during checkout:

Argument 1 passed to Payum\Core\Gateway::addAction() must implement interface Payum\Core\Action\ActionInterface, string given.

Because reason is empty, the payment is marked as Authorised !!
An example of a real Adyen notification:

originalReference=
reason=
additionalData.hmacSignature=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
merchantAccountCode=xxxxxxxxxx
eventCode=AUTHORISATION
operations=
success=false
paymentMethod=ideal
currency=EUR
pspReference=4755881009859805
merchantReference=*****3051-7409
value=4990
live=true
eventDate=2020-04-28T19:10:18.42Z

This code is wrong.

          if (AdyenBridgeInterface::AUTHORISATION === $httpRequest->request['eventCode']) {
                if (true === filter_var($httpRequest->request['success'], FILTER_VALIDATE_BOOLEAN)) {
                    $httpRequest->request['authResult'] = AdyenBridgeInterface::AUTHORISED;
                } elseif (!empty($httpRequest->request['reason'])) {
                    $httpRequest->request['authResult'] = AdyenBridgeInterface::REFUSED;
                }
            }