bis-med-it / pysdmx Goto Github PK

Connect the Message class to the XML parsers and writers for metadata.

This depends on #42 #40 and #39

          @sosna please add this after the PR.

Originally posted by @javihern98 in #27 (comment)

Adding a post init check to ensure an annotation is not generated without an ID.

Generating code proposal using class hierarchy to adapt it to the SDMX-IM (as is pure form). Modify convenience methods and classes to adopt this structure.

Add methods to ItemScheme and Item to write XML files from the classes

Implement this following the suggestion defined here:

#31

Add classes DataProvider and DataConsumer that inherit from Organisation.

Use Path(file).parent to be able to execute the tests from any PYTHONPATH OR

Use global fixtures in conftest.

@stratosn and @sosna any preference on any of these? It is necessary for us to test properly the whole library.

Example (we could any of them in conftest.py to generate a global fixture, but we prefer the Proposal one):

• Previous

@pytest.fixture()
def body():
    with open("tests/fmr/samples/orgs/agencies.fusion.json", "rb") as f:
        return f.read()

• Proposal

@pytest.fixture()
def body():
    samples_path = Path(__file__).parent.parent / "samples"
    with open(samples_path / "orgs/agencies.fusion.json", "rb") as f:
        return f.read()

For global fixture, we could use a mark and add the request param to the fixture:

conftest.py

@fixture
def agencies_path(request):
    base_path = request.node.get_closest_marker('input_path').args[0]
    return "samples" / "orgs" / "agencies.fusion.json"

Any test file

pytestmark = pytest.mark.input_path(Path(__file__).parent)

pytest.ini

[pytest]
addopts = --strict-markers
markers =
    input_path: directory where tests data files are stored

Dear repository owners, 🌟

As your repository is related to SDMX (Statistical Data and Metadata Exchange), please consider adding the sdmx topic to it. This will help other developers discover and engage with your project more easily.

To associate your repository with the sdmx topic, visit your repo's landing page and select 'manage topics'. Let's make SDMX-related projects more visible and accessible! 🚀

Thank you for contributing to the community! 🙌

For detailed instructions on how to add topics to your repository, refer to the GitHub documentation.

Happy coding! 🌐👩‍💻👨‍💻

Add metadata parsers to generate Codelist, Code, Concept Scheme, Concept, Agency

Implement Message class based on MsgSpec/PyDantic as specified in SDMXthon.

https://docs.sdmxthon.meaningfuldata.eu/packages/model/message.html

Implement read_xml method and add lxml dependency. Implement xml validation based on schemas.

Check that Agency is set as a post init check.