Comments (6)
@PeteHaitch Would you be open to the possibility of keeping length-1 centers valid in DelayedMatrixStats, at least for a little bit longer? Length-1 centers in DelayedArray, SparseArray and sparseMatrixStats have been supported for a while and they didn't start issuing warnings recently despite the fact that matrixStats doesn't like them anymore. So having them now cause a hard error in DelayedMatrixStats is inconsistent with DelayedArray, SparseArray and sparseMatrixStats .
Also I can't think of anything wrong with supporting length-1 centers -- they're just a convenience like recycling.
If you agree with this, I'll submit a patch to DelayedMatrixStats. The patch will simply recycle length-1 centers to nrow(x)
or ncol(x)
.
Thanks,
H.
from delayedarray.
Argh sorry for this.
I was trying to follow the defunct-ification by Henrik in matrixStats (HenrikBengtsson/matrixStats#254), since we've (mostly) tried to mimic its API.
A patch would be welcome (it might just be reverting the most recent commits).
from delayedarray.
No worries. Working on it. Will also involve patching MatrixGenerics to make things consistent across the board.
from delayedarray.
PR for DelayedMatrixStats ready: PeteHaitch/DelayedMatrixStats#101
from delayedarray.
Thanks, @hpages
I'm in the midst of resolving OSCA build issues and I'll then turn to this (hopefully Friday).
from delayedarray.
Fixed by PeteHaitch/DelayedMatrixStats#101
from delayedarray.
Related Issues (20)
- Where can i find the old version HOT 1
- Can't `cbind` DelayedArray instances with other matrix-likes
- More elements in the method signature (2) than in the generic signature (1) for function ‘type<-’ HOT 2
- Bioconductor devel / multiple methods tables found for ‘aperm’ HOT 1
- Install error HOT 2
- `set_grid_context()` changed in `RELEASE_3_17` HOT 2
- Thoughts on migrating from `read_sparse_block()` to SVTs HOT 3
- rowRanges/colRanges not preserving row/col names HOT 2
- colMaxs/rowMaxs and colMins/rowMins useNames behavior incorrect in RELEASE_3_17 HOT 2
- `NSBS` method for `DelayedArray` objects? HOT 3
- Unable to find an inherited method for function ‘OLD_extract_sparse_array’ for signature ‘"CSR_H5SparseMatrixSeed"’ HOT 2
- Feature request: add `BPCell` backend HOT 8
- Feature request: make `seedApply` as a generic function HOT 5
- More informative error than `the supplied seed must support extract_array()` HOT 3
- Inconsistent `dimnames` after matrix multiplication with zero-column output HOT 2
- Importing DelayedArray messes up as.vector() for Arrow arrays HOT 1
- `base::cbind()`
- the problem "the supplied seed must support extract_array() " HOT 3
- Failed to install geneLenDataBase HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delayedarray.