Comments (2)
That all makes sense, thanks for the explanation.
I'll just tweak DelayedMatrixStats tests in RELEASE_3_17
to accommodate that.
from delayedarray.
This was a concious decision I made a long time ago, that all row/col summarization methods defined in DelayedArray would follow the lead of rowSums
/colSums
and rowMeans
/colMeans
in base R by propagating the rownames
/colnames
, independently of what matrixStats was doing. So at the time I chose consistency with base R over consistency with matrixStats.
Note that I made the same choice for SparseMatrix objects (but those are much more recent). With BioC 3.17:
library(SparseArray)
rowMaxs(SparseArray(x))
# R1 R2 R3
# 4 5 6
I'm not too keen to change this just in BioC 3.17. rowMaxs
/colMaxs
and rowMins
/colMins
have propagated the rownames/colnames forever on a DelayedMatrix object, and, starting with BioC 3.18, this behavior is now consistent with matrixStats and MatrixGenerics. So making an exception for BioC 3.17 doesn't sound like a good idea. Plus this would mean changing the behavior of code that was released more than 3 months ago.
Hope that makes sense?
H.
from delayedarray.
Related Issues (20)
- Can't `cbind` DelayedArray instances with other matrix-likes
- More elements in the method signature (2) than in the generic signature (1) for function ‘type<-’ HOT 2
- Bioconductor devel / multiple methods tables found for ‘aperm’ HOT 1
- Install error HOT 2
- `set_grid_context()` changed in `RELEASE_3_17` HOT 2
- Thoughts on migrating from `read_sparse_block()` to SVTs HOT 3
- rowRanges/colRanges not preserving row/col names HOT 2
- `NSBS` method for `DelayedArray` objects? HOT 3
- Unable to find an inherited method for function ‘OLD_extract_sparse_array’ for signature ‘"CSR_H5SparseMatrixSeed"’ HOT 2
- Feature request: add `BPCell` backend HOT 8
- Feature request: make `seedApply` as a generic function HOT 5
- More informative error than `the supplied seed must support extract_array()` HOT 3
- Inconsistent `dimnames` after matrix multiplication with zero-column output HOT 2
- Importing DelayedArray messes up as.vector() for Arrow arrays HOT 1
- DelayedMatrixStats no longer supports scalar `center=` arguments HOT 6
- `base::cbind()`
- the problem "the supplied seed must support extract_array() " HOT 3
- Failed to install geneLenDataBase HOT 5
- Where can i find the old version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delayedarray.