bioconda / bioconda-actions Goto Github PK

(Please move this to another project if desired).

Currently PRs to recipes can be approved by any member. A particular stumbling point with this is when the bot picks up a change to a pypi repo and makes an automatic PR and blindly performs a review and approves the PR with no knowledge of the package. As examples a new package may require requirements updating, or a change to a build script in order for the resultant pacakge to work correctly, as the build process does not run complete testing more simply "if it compiles it works".

IIRC conda-forge has the mechanism that only maintainers listed in the meta.yaml can approve a PR.

If we get a 201 response code from a push to a PR branch, this likely means the contributor did not check the "Allow edits from maintainers" box. We may want to reflect that in the Bot response message.

ref: bioconda/bioconda-recipes#19753 (comment):

I encountered an error updating your PR branch. You can report this to bioconda/core if you'd like.
-The Bot

Failed with: https://github.com/bioconda/bioconda-recipes/commit/7e49c223dbcf2737533de3518724e53632778d59/checks?check_suite_id=402686325#step:3:463

git push
To github.com:pravs3683/bioconda-recipes.git
 ! [remote rejected]     fix_quantwiq-iq -> fix_quantwiq-iq (permission denied)
error: failed to push some refs to '[email protected]:pravs3683/bioconda-recipes.git'
the response code was 201
##[error]Node run failed with exit code 1

since the PR does not allow edit from maintainers.