billionoysterproject / digital-platform Goto Github PK

When you go to the Data page and click the "Download" tab, after you select one or more filters you can view data from published expeditions in addition to being able to download that data as a csv.

While looking through that filtered data on the web page, if you find an interesting data point you would click on that expedition's name to be taken to that expedition's page to find out more. But after you visit that expedition's page, if you click the back button in your browser it takes you back to the main Data page, not that last filter you created. Our participants would like it if the platform took you back to that last filter (like how a Google search works). (Central Park East II middle school request)

When you go to the Data page and select the "Download" tab, after you select one or more filters you can view data from published expeditions in addition to being able to download it. But the expedition names (potentially hundreds of them) display horizontally across the page (where there is limited real estate) instead of vertically (where there is unlimited real estate). See screenshot.

Our participants would like to flip it so the expedition names to run vertically down the page, and the selected parameter(s) runs horizontally across the page.

This is an enhancement which will likely improve the perception of the platform.

My BOP username is Ira Gershenhorn.

Append the Start Date and End Date labels with (YYYY-MM-DD) so users can just start entering a proper SQL date rather than wait for the date picker to popup.

Currently, non-SQL formatted dates seem to be ignored. I am recommending including the SQL format after the Start Date and End Date labels on the filter screen.
This is how that screen looks now.

I am suggesting that we see Start Date (YYYY-MM-DD) and End Date (YYYY-MM-DD)

In modules\expeditions\client\views\filter-expeditions.client.view.html ,
Line 17
Replace:
<label class="control-label" for="startDate">Start Date</label>
With:
<label class="control-label" for="startDate (YYYY-MM-DD)">Start Date</label>

and on
Line 32
Replace:
<label class="control-label" for="endDate">End Date</label>
With:
<label class="control-label" for="endDate">End Date (YYYY-MM-DD)</label>

If I could, I would label this as enhancement and help wanted.

On the Data>Download page, when you download the data as a csv, the expedition names run horizontally across the spreadsheet in row 1. It's more useful for our participants to have the expedition names run vertically down the spreadsheet in column 1, and for the selected parameters (like salinity or oyster measurements) to run horizontally across the spreadsheet in row 1.

This is how it currently displays:

This is how we'd like it to display:

This is an enhancement. There is no bug.

My BOP user name is Ira Gershenhorn.

I took the following screenshot of the result of filtering Community>People by gershenhorn and then clicking on the image of the one returned person (me). Its obvious to me that Data represents Published Expeditions and Launched Expeditions represent expeditions NOT published. I realize that an expedition only becomes Data once its been published but it just strikes me that there's this syntactic change. I would prefer if Data was followed by (Published Expeditions) and Launched Expeditions were followed by (expeditions not published), because to my mind the expeditions listed under Data certainly were launched.

The file where this appears seems to be \modules\profiles\clients\views\view-user-content.client.view.html
in Lines 91, 105, 150, 162 (there are two cases of Data and Launched Expeditions).

There seems to be two different presentations based on whether one is the TeamLead or not.

If I could I would tag this as enhancement and help wanted.

On the Data>Download page, when you download the data as a csv and view it in a spreadsheet application like Excel, for certain parameters like "oyster measurements," some cells will contain multiple data points. Take a look at the "oyster measurements" download:

Most cells contain one data point- for example, the total number of live oysters on Substrate Shell 1. But the "Measurements (mm)" row includes the length of all the oysters on one substrate shell, separated by commas within the cell.

To fix this, I'm inclined to think that there should be two separate oyster measurements downloads. One csv should contain information for each of the 10 substrate shells, including:

• Total number of live oysters at baseline
• Total mass of live oysters at baseline (g)
• Total number of live oysters on shell
• Total mass of scrubbed substrate shell + oysters + tag (g)
• Minimum size of live oysters (mm)
• Maximum size of live oysters (mm)
• Average size of live oysters (mm)

So this spreadsheet would look something like this:

The second download should contain the length of each oyster measured, with each measurement appearing in a separate cell. So it would look something like this (this view is with the rows and columns transposed as per #572 )

On https://platform.bop.nyc/expeditions/data, using Firefox. I just tried it in Chrome. So much better - not really - faster, but still get no return. A completely different presentation. I think you just need a note that one should use Chrome and avoid Firefox at all costs.

I set a filter of Start Date = 2018-06-01 to End Date= 2018-07-01. I hit ENTER and got the swirly thing on top. It disappeared. I selected all parameters. I hit Download. Again I got the swirly thing. Then nothing. Once when I set a filter of 2018-07-01 and 2018-09-01 I got the export-expeditions.csv popup but not consistently.

With the Start Date = 2018-06-01 to End Date= 2018-07-01, I get the following information:
Your current filters result in the following 10 expeditions: 3rd Expedition - Year 2 , 2018-0609 Demo for Summer on the Hudson , First Expedition Station 18 , First Expedition Station 190 , First Expedition Station 192 , First Expedition Station 189 , First Expedition Station 191 , Science Barge Summer 2018 #1 , Cage 188 Second Observation , Science Barge Summer 2018 #2 ,

So it is finding expeditions.
I tried unsetting a data selection and resetting. I got the swirly thing

This is an enhancement, but adding methods should improve the quality of the data. A turbidity tube was used at the BOP training but one wasn't included in the kit and I didn't get one. I measured turbidity either using a Secchi Disk or by how much of the rope was wet. Since turbidity tube was the only available answer, I used it, even though it was incorrect. I do not think that I'm the only BOP client that does not have a turbidity tube.

My BOP username is Ira Gershenhorn.

There is only one Turbidity method and that method does not work for people who have no turbidity tubes.

I do not know how the methods get into into the system.
I see there is a file in scripts\mongo-load called metaTurbidityUnits.json . I don't know if that is edited directly or created from metaTurbidityUnits.json

If the latter, then I suggest, increasing the number of methods by increasing the number of lines in the csv.

In metaTurbidityMethods.csv
which currently has:

order,label,value
1,Turbidity tube,turbidityTube

Add 3 more methods:

2,Secchi Disk,Secchi Disk
3,Wet rope, Wet rope
4,Other,Other

When you go to the Data page and click the "Download" tab, after you select one or more filters you can view data from published expeditions in addition to being able to download that data as a csv.

But the page takes a very long time to load each time a filter is selected. This is especially confusing for our middle school students who think they're not using the feature correctly when the page appears to freeze or data does not display as quickly as they are expecting. This is exacerbated the more filters they select. (Central Park East II middle school request)

Here's an example of the data participants are looking for (after it loads):

This is an enhancement.

When choosing Community > People in the sidebar, the returned user list is not sorted. This makes it difficult to find people. I suggest ordering the list by lastName.

My BOP username is Ira Gershenhorn.

In \modules\profiles\client\views\user\list-users.client.view.html
Line 75
Replace:
<tr ng-repeat="user in users" ng-click="openViewUserModal(user)">
with:
<tr ng-repeat="user in users | orderBy 'lastName'" ng-click="openViewUserModal(user)">

Disclaimer: I cannot tell if this code is used anywhere else and if that anywhere else relies on the absence of ordering.

If I were able to, I would tag this issue as enhancement and help wanted.

This is an enhancement.

I think this change should be made because the My Expeditions list should be sorted and currently is not and a sort order by descending expedition date is the most natural. The expedition one is most likely to edit is the most recent one and that expedition should be on top.

My BOP Digital Platform name is Ira Gershenhorn

Label issue with - Expeditions

The precise change suggested is in:
BOP-Digital-Platform-master\modules\expeditions\client\views\list-expeditions.client.view.html
Line 30:
Replace :

<tr ng-repeat="expedition in vm.myExpeditions" ui-sref="expeditions.view({ expeditionId: expedition._id })">
with
<tr ng-repeat="expedition in vm.myExpeditions | orderBy: '-monitoringStartDate'" ui-sref="expeditions.view({ expeditionId: expedition._id })">

The only change is adding: | orderBy: '-monitoringStartDate'"