billinghamj / vrm-node Goto Github PK

First of all, thanks for this nice library. It works great server-side, but it doesn't support client-side because of the use of fs.

Is there any reason why it can't require the VRM formats like below?

const formats = [
	require('./diplomatic.js'),
	require('./gb-1903.js'),
	require('./gb-1932.js'),
	require('./gb-1963.js'),
	require('./gb-1983.js'),
	require('./gb-2001.js'),
	require('./military.js'),
	require('./ni-1903.js'),
	require('./ni-1966.js')
];

Discovering the formats dynamically is better, but the list of formats seems pretty static.

Hi, thanks for creating this, it's great.

I'm having an issue with two VRMs (out of a dataset of ~10,000), where the info method is returning null, despite the VRMs being valid.

The two VRMs are VIP1 and Q362KUA, both of which are registered vehicles in the UK.

You can verify these vehicles are registered at https://vehicleenquiry.service.gov.uk/ (VIP1 is a Rolls Royce and Q362KUA is a Caterham).

Q362KUA is a Q registration number (see https://www.gov.uk/vehicle-registration/q-registration-numbers), but should match the gb_1983 format.

VIP1 looks like the gb_1932 format.

Do you know why these VRMs return null?