bilka2 / changemapsettings Goto Github PK

Due to moving the gui to gui.screen, it's no longer restricted to 2/3 of the screen height, so the elements don't need to squash as early/not squash at all.

Could you update this mod to 0.17 ?

https://forums.factorio.com/97131 / https://github.com/wube/Factorio/commit/e1435e419d880d232199e52735a61973c28324ee

Game doesn't use autoplace-control-names for the ores since 1.1.22: https://github.com/wube/Factorio/commit/ba32657f47f9b5423c9c806ad8d26cb70460fd9d.

I noticed that you intentionally exclude "planet-size" from appearing in the map-gen gui if it's present as one of the autoplace_control_prototypes, which is indeed a good idea for Space Exploration players.

The issue is that the "planet-size" autoplace_control doesn't actually get preserved if the user were to make/apply any map-gen changes using the mod. Adding the following to control.lua:131 would prevent this issue from happening.

if player.surface.map_gen_settings.autoplace_controls["planet-size"] then
    settings.autoplace_controls["planet-size"] =
        player.surface.map_gen_settings.autoplace_controls["planet-size"]
end

Thanks in advance for looking into this. If you accept PR's, I'd be happy to submit a small PR with that change.

Map gen settings are already unlimited. Maybe the option could work for both map settings and map gen settings, which would mean adding limits for the map gen settings.

Old text from my notes (last edited October 2020):

make map settings not have limits/have override limits checkbox or something

When removing the Change Map Settings mod from a game, it removes its button from the top left of the game screen, and this is OK.

However, Creative Mod also places a button at the same spot. When Change Map Settings is removed from the game, it inadvertently also removes Creative Mod's button, which is terribly wrong.

This is causes a big issue, because the only way to restore Creative Mod's button is by removing it and adding it again to the game, which implies on removing all Creative Mod stuff from the game, which is a no-go. So while this is not fixed, one must decide either not having both mods installed, or to never remove Change Map Settings Mod from its game, otherwise Creative Mod will be permanently damaged.

As an additional idea, I would suggest adding an option for showing/hiding the Change Map Settings button, since it is not frequently used in game. This would be an elegant solution for reducing unused UI elements from the game view. This is important because game debug messages are obstructed by this button.

Hi,

if you make changes with the mod, save and remove it from the loaded mods, ALL ore deposits are MUCH smaller, even the ones already generated.

I was wondering, are the changes I made to my map settings still applied to new new chunks even after I have this mod uninstalled?

Well as per title, I can't seem to find the configuration to change to expensive prices for crafting/science...