bibleget-i-o / bibleget-google-docs-addin Goto Github PK

Since most Catholic versions of the Bible offer both Greek and Hebrew versions of certain Bible texts (such as the Book of Esther), the API now accounts for this by offering a new parameter preferorigin.

We need to account for this when retrieving a quote by giving the option to prefer the Greek or the Hebrew origin.

From user feedback:
Similarly to the BibleGet add-on for Microsoft Word, it could be useful to have a function that would transform a selected Bible reference in the document into a Bible quote.
And other than that, a function that could scan a document and transform Bible references into Bible quotes.

I don't really care a whole lot about whether variables should be lowercase, camelcase, uppercase, propercase, or whatever. These conventions are not always agreed upon, and can even tend to change in the general consensus of the programming community.
However it is useful to choose one convention and stick to it within the same project.
In this case, the first set of variables defined for the user preferences were in propercase.
Then, in a later major rehaul of the code with a number of large additions, constants which helped define English language values for the user preferences were introduced along with a number of new user preferences, which were then organized into groups. Most of the new user preferences were defined in uppercase.
Now whether we use uppercase or propercase I don't really care, I just think they should be consistent with one or the other.

Other than regular dashes, any other kind of dash should be accepted so as to avoid unexpected errors (for example when someone copy/pastes a reference query that has an emdash in it).

This has been done already for the Microsoft Word add-on: 055a6e70c6f14d96ba7ffcf9d72b5152edcd2c0a.

And in the API endpoint engine: b658fa93a1f662d7dc61e538395d253504e0580f.

In the add-on for Microsoft Word, the highlighting of the search term in the search results not only highlights the exact match of the search term, but also lightly highlights the rest of the word for a better user experience.
This means a slightly more advanced version of the addMark function. The Word add-on source code can be used for reference.

By default, full text search will limit matches to words of at least 4 characters. The BibleGet endpoint has brought this limit down to 3 characters.
The exactmatch option will use a regex match rather than a fulltext search, and will only return exact matches, not partial matches. This also brings the limit down to 2 characters.

CodeFactor found an issue: Unexpected duplicate selector "input[type="button"].green.gapp-addon:hover", first used at line 288 (no-duplicate-selectors)

It's currently on:
Stylesheet.html:288
Commit fa3e108