bibeknam / algorithmtutorprograms Goto Github PK

View Code? Open in Web Editor NEW

161.0 5.0 151.0 61 KB

Program Codes for AlgorithmTutor.Com

Home Page: https://algorithmtutor.com

C 12.25% C++ 38.96% Java 27.94% Python 20.85%

algorithm tutorials

algorithmtutorprograms's People

Contributors

Stargazers

Watchers

Forkers

hagar-usama dzand harris854 arminmaz anushas06 cooleo anupkumargupta donrazor2 benthem stelaalmeida mozhagn1991 leonkolyang shayd2110 armeriawang applerengg jerryrwu bengisupinar lawhorne01 gusssoares vipulsharma18 ov1n nhnguyen99 vincentlavello jarrettmonty abhishek-singh-iit stl00 harshitgoel1110 mayankprhr tunsuy chrisblom nil0481 estructuradedatosunju ezxfv sweetpand joel-nickson losaohan 8715shadow adrianoalveslima ykchahine rafaruiz-clavijo renanrosa ssheff febikambu talden-key lightfindyou kotk007 sihatafnan abhishekgaire seeair nazmul1850 noorsheikh amethystgear nasrullo simmi622 manu1nd abdel-rhman1 itsbahgat violet360 lregan666 simranbiswas youngjay9 tvrt0001 arunudhaya smilingmega mjdahlquist24 victoranto punitive2501 nathan-quick dulatufa spatikah nanjerry pratikpatelx meguefuso9983 critalic jeetintyagi arsyaputraa zzilman iefiru antonsustavov joner-perey prakhar7651 ivytan29 archit03 anvit26 sjnaka mostafaahmed660 adam-zhang canoebyguitar aishika-pal agarwaly899 ghackg11 yargachin-wye ollie-beep-bop kamyu104 asaashraf asad006 antongrigorev mredelis j1-e1 karej

algorithmtutorprograms's Issues

splay_tree - search_tree function

The function does not return anything.
It should "return x"

Single letter variable use.

Single letter variable use. Your code is extremely hard to read due to the lack of self documenting variables.

Bug report:

algorithmtutorprograms/data-structures/red-black-trees/RedBlackTree.cpp

Line 115 in 11ef340

if (s->right->color == 0 && s->right->color == 0) {

I believe it should be "s->left->color == 0 && s->right->color == 0"

C++ RedBlack Tree: duplicate check in 'FixDelete' function: 's->right->color ==0'

https://github.com/Bibeknam/algorithmtutorprograms/blob/bbbc4ff16b15a2fd50308c996e236d124a024b85/data-structures/red-black-trees/RedBlackTree.cpp#L115C56-L115C56

Python3 print

There are two print statements that should have brackets for python3 on the splay_tree

looks like it should be s->left s->right

algorithmtutorprograms/data-structures/red-black-trees/RedBlackTree.cpp

Line 115 in 705130f

if (s->right->color == 0 && s->right->color == 0) {

usage after delete

https://github.com/Bibeknam/algorithmtutorprograms/blob/11ef340f8c8e60839a9dff395dd52b8752c537a6/data-structures/red-black-trees/RedBlackTree.cpp
line 303
z is pointing to tree and is deleted
Subsequent lines use the tree which is already deleted

problem with balancing

don't balance after deletion

Implementations error

This line if code checks only the right child colour. It should check the left child as well.

algorithmtutorprograms/data-structures/red-black-trees/RedBlackTree.cpp

Line 115 in 705130f

if (s->right->color == 0 && s->right->color == 0) {

RB Tree is leaning right

That's not a bug, I am just curious why it is the case.

int main() {
  RBTree bst;
  for (int i = 0; i < 31; i++) {
      bst.insert(i);
  }
  bst.prettyPrint();

  return 0;
}

produces a tree without any violations but at the other time it isn't really balanced.

R----7(BLACK)                                  
     L----3(BLACK)                             
     |    L----1(BLACK)                        
     |    |    L----0(BLACK)                   
     |    |    R----2(BLACK)                   
     |    R----5(BLACK)                        
     |         L----4(BLACK)                   
     |         R----6(BLACK)                   
     R----15(RED)                              
          L----11(BLACK)                       
          |    L----9(BLACK)                   
          |    |    L----8(BLACK)              
          |    |    R----10(BLACK)             
          |    R----13(BLACK)                  
          |         L----12(BLACK)             
          |         R----14(BLACK)             
          R----19(BLACK)                       
               L----17(BLACK)                  
               |    L----16(BLACK)             
               |    R----18(BLACK)             
               R----23(RED)                    
                    L----21(BLACK)             
                    |    L----20(BLACK)        
                    |    R----22(BLACK)        
                    R----25(BLACK)             
                         L----24(BLACK)        
                         R----27(RED)          
                              L----26(BLACK)   
                              R----29(BLACK)   
                                   L----28(RED)
                                   R----30(RED)

I stumbled upon playing with my own implementation and just looked around for something else to compare with.

What is the license on this code?

I poked around a bit and couldn't find a license statement on the code here or at the main website. Each file should have a license statement as well as a master license at the top of the repository.

Unused private function 'initializeNULLNode' in RedBlackTree.cpp

https://github.com/Bibeknam/algorithmtutorprograms/blob/bbbc4ff16b15a2fd50308c996e236d124a024b85/data-structures/red-black-trees/RedBlackTree.cpp#L28C1-L28C1

bibeknam / algorithmtutorprograms Goto Github PK

algorithmtutorprograms's People

Contributors

Stargazers

Watchers

Forkers

algorithmtutorprograms's Issues

Recommend Projects

Recommend Topics

Recommend Org