biakaveron / debug-toolbar Goto Github PK

I've just installed and applied toolbar in Kohana::modules() (did not call Debugtoolbar::render()) and I have this error:
Fatal error: Call to a member function as_array() on a non-object in C:\OpenServer\domains\cmf1\modules\debug-toolbar\classes\Kohana\Debugtoolbar.php on line 499

http://github.com/cadorn/firephp-libs :
THIS PROJECT HAS MOVED TO THE FOLLOWING REPOSITORIES:
https://github.com/firephp/firephp
https://github.com/firephp/firephp-core

Hello!

Maybe it will be easier to store images in CSS file? At this moment images can be easily moved into CSS (and placed as backgroud to each block where they are used) and base64 encoded...

Hi there,

it would be nice if this module would be conform to the kohana codestyle conventions because my jenkins shows me more than 500 warnings. Especially the firephp.php is a problem. And if i do it all changes will be gone on the next update.
What do you think?

Cheers
Chris

Есть идеи по добавлению функционала (заимствованы из http://alertdevelop.ru/projects/profilertoolbar ):

1. Вкладка Cache, где отображаются вызовы get/set/delete и lifetime.
2. Подсветка синтаксиса на вкладке SQL.
3. Возможность добавления нескольких значений в одну вкладку в Customs. Сейчас для каждого вызова add_custom создается отдельная вкладка.
   Возможно ли это реализовать?

Собственно ошибка в том, что панель выводится во всех случаях, не учитывая mime контента.
Это не правильно на мой взгляд. Предлагаю следующее возможное решение в лоб:

В DebugToolbar::is_enabled после проверки что запрос не пустой и не ajax добавляем проверку mime контента.

Что-то типа такого:

$all_headers = headers_list();

foreach($all_headers as $header)
{
    list($key, $value) = explode(': ',$header);
    if (strcasecmp('content-type', $key) == 0 AND strcasecmp('text/html', $value) != 0)
    {
        return FALSE;
    }
}

Панель нам нужна только при просмотре html страниц, соответственно для всех других страниц/типов ответа она должна блокироваться.

Если найдется более удобное решение то неплохо было бы на него посмотреть.

I don't see anything in the session variable.

Is this because I'm using the database for session management, and the connection is closed by the time ::render is called as a registered shutdown function?

панель не должна отрисовываться, если выполнение прервано с bootstrap.php. Т.е., если запрос еще не создан.

Вот тут необходимо добавить вот это:

if (Request::initial() == NULL OR Request::initial()->is_ajax())

Думаю должно помочь.

Please add a readme...

I just have no idea how use your lib! Need to read the code now.

Is there a way to add in a custom tab information from anywhere in the application?

Like showing debug information of own modules or classes in an extra tab.

For example in a static function:

Debugtoolbar::add_tab('tabname',Kohana::debug($some_variable));

I don't want to change your module if there is anything like this planed.

Hi,

I've taken your code and refactored it to do a couple of things (not sure if I broke anything though) and it's fairly major so I'm not sure if I should do a fork + pull request. Here are the changes I have made:

• Renamed all filenames and PHP classes to debugbar (one word) and not have debug-toolbar or toolbar variants
• Made it more HMVC (cascading) so the main code is now in a subdir called "kohana" and the base class "Debugbar" is blank (extends Kohana_Debugbar)
• Created a new controller Kohana_Controller_Debugbar (also a blank class Controller_Debugbar) that follows the same convention as the userguide in terms of pulling up "media" files (js, css and img) - they are created with Route:set() in init.php
• Moved all the css, js and img directories under a subfolder called media and using route to serve them up (so it's more portable) and renamed/moved css and js files to media/css/debugbar.css, media/js/debugbar.js - no need to copy images to DOCROOT (same as userguide)
• Made everything output right before the </body> tag - used to have CSS output inline right before the tag which muddled up the View Source (scroll way down to see your code) -- now the JS & CSS are NOT inline and are sent to the output right before the debugbar HTML

TODO

• Figure out how to enable this without touching index.php -- possibly somewhere in the after() of your base controller
• CSS and JS cleanup to make everything be "debugbar" vs a mix of debug-toolbar, toolbar, etc.

What do you think?

Thanks,
Chris

Can you add $_FILES into "vars" tabs? It's very helpful when debugging file uploads.

Должно быть:

// Render Debug Toolbar on the end of application execution
if (Kohana::$config->load('debug_toolbar.auto_render') === TRUE)
{
register_shutdown_function('Debugtoolbar::render');
}

Sometimes KDT should return template (string) instead of rendering.

KDT should ignore some routes (css, js etc). This is important if auto_render is ON

Auto_render = true option does not display the toolbar in the debug interface, but via Firebug can view information on the toolbar.

But when the auto_render = false toolbar displays correctly.
Always IN_PRODUCTION = false in my development environment
There should be the opposite?

На вкладке Ajax не отображается информация при использовании jQuery ajax запросов. Kohana 3.3, jQuey версии 1.10.1 (другие также пробовал).

Seems like the project is missing a license. Could you please specify what license it is released under?