betsybaileyy / cs_3 Goto Github PK

• Binary Search Tree :
  • Typo in insert function: Create new node with data value ‘item’. You did it for parent.left but forgot it in parent.right. Fix this!
  • Recursive find_parent_node is not working properly. A few bugs I noticed: when the node is None, you should return the parent because that is the location where the node should be inserted! It does not exist already. Also, the way that you are passing in parameters is not right. If you call a function, you should pass it in like —> find(item, tree_node), NOT like —> find(item = item, tree_node = tree_node). The second version is for when you initialize a function, and need to create optional parameters.
  • All else works!
• Publish your blog post with minimum 800 words and 3 images for full credit.

Good job submitting the second coding challenge. Here's how you can improve:

• ArrayQueue is not implemented. This is required. Reach out if you feel blocked :)
• Missing is subset method in Sets, and failing multiple tests. There are a couple of typos in your tests. You also need to add/subtract from your size property when you add or remove an element from the set. Also remember that hash tables have a method called keys, so it must be called as a function —> map.keys( ). (Its a bug in your union function). Debug your sets against your test functions. :) (Also, in your sets tests, you should not have to access the map property that stores the hash table. You should be able to use set.contains(item), by using your contains method for your sets.

• Search.py: In your recursive binary search function, you never initialize left to a integer. Thus, your function throws an error when you try to do math with ‘left’ because it is None.
• Palindrome iterative does not pass tests. Try to use print statements and the given test cases to see what’s going on.
• I see that you annotated for time complexity. Do the same for space complexity. How much space is your function using? Are you allocating any arrays, sets, dictionaries, etc?