berzniz / backbone.getters.setters Goto Github PK

Would it be complicated to add the GS feature on collections ?

I've been using this plugin in the past and only now came to realise that you haven't included a license at all, which means nobody but you is really allowed to use this legally.

If this is intended, it might be worth making a note of that in the README, but if it isn't it would be lovely if you could add a license such as MIT/BSD/WTFPL, so this can legitimately be used.

I think it would be productive if the toJSON () method was overridden so that getters include results as far as this only include the original attributes.

  something like this:

toJSON : function () {
           var gettersJSON = {};
            _.each(this.getters,function (getter,name) {
                if (_.isFunction(getter)) {
                     gettersJSON[name] = getter.call(this);
                }
            }.bind(this));
            return _.extend(Backbone.Model.prototype.toJSON.apply(this,arguments),gettersJSON);
}

The bug is related to prototyping object, which shouldn't be done, but is 😄, so worth watching out for:

// Go over all the set attributes and call the setter if available
for (attr in attrs) {}  # if Object.prototype has been changed, this will include those changes
for (attr in _(attrs).keys()) {}  // by the power of underscore, not no mo'.

The feature is one I baked into getters.setters today, that allows for a "formatter" to be passed into the getter/setters.

var m = new MyModel();
m.get('datetime');  // => Date object
m.get('datetime', 'time');  // => e.g. '13:45:12'
// WUH!?

var MyModel = Backbone.GSModel.extend({
  getters: {
    datetime: function(format) {
      var ret = this.rawget('datetime');  // also added, to make this easier.  calls Backbone.model.get.
      if ( format == 'time' ) {
        var time = ret.hour + ':' + ret.minute + ':' + ret.second;
        // real version has string padding, am/pm, etc.
        return time;
        }
      return ret;
    }
  }
});

If you're interested, I'll format this as a pull request.

Hey, maintainer(s) of berzniz/backbone.getters.setters!

We at VersionEye are working hard to keep up the quality of the bower's registry.

We just finished our initial analysis of the quality of the Bower.io registry:

7530 - registered packages, 224 of them doesnt exists anymore;

We analysed 7306 existing packages and 1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).

Sadly, your library berzniz/backbone.getters.setters is one of them.

Can you spare 15 minutes to help us to make Bower better?

Just add a new file bower.json and change attributes.

{
  "name": "berzniz/backbone.getters.setters",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.

NB! Please validate your bower.json with jsonlint before commiting your updates.

Thank you!

Timo,
twitter: @versioneye
email: [email protected]
VersionEye - no more legacy software!