bepasty / bepasty-client-cli Goto Github PK

I get this error after installing with python3, this is not the case with python2:

Traceback (most recent call last):
  File "/usr/local/bin/bepasty-cli", line 11, in <module>
    load_entry_point('bepasty-client-cli==0.3.0', 'console_scripts', 'bepasty-cli')()
  File "/home/martin/.local/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/martin/.local/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/martin/.local/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/martin/.local/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/bepasty_client_cli-0.3.0-py3.6.egg/bepasty_cli/cli.py", line 200, in main
  File "/usr/local/lib/python3.6/dist-packages/bepasty_client_cli-0.3.0-py3.6.egg/bepasty_cli/cli.py", line 262, in upload
AttributeError: 'str' object has no attribute 'decode'

the code that deals with file content read from stdin reads the complete input into memory to create a BytesIO object.

that's ok for small stuff, but not for larger stuff as it can allocate lots of memory, even more than you have.

using a tmpfile for that is also problematic as the tmpfile may reside on a tmpfs (that has limited size and is in RAM also). but at least this would be an issue not caused by our code. :)

the problem that requires above mentioned solutions is that we need to seek inside the data, at least with the current implementation, and that is not possible when using stdin directly.

http://click.pocoo.org/

Load defaults for all arguments from a configuration file and overwritten values by given cmdline arguments.

• ignore list
• use default for fname only if piped input
• use default for ftype only as fallback if it cannot be magically detected

Questions:

• security for token - is chmod 600 for the file enough?
• file format?
• cmdline argument that triggers "store current cmdline arguments to the conffile"? (makes it less error prone for users, allows to use less human friendly file formats like json)