benjamn / optimism

Composable reactive caching with efficient invalidation.

optimism

Composable reactive caching with efficient invalidation.

optimism's Issues

An in-range update of immutable-tuple is breaking the build 🚨

The dependency immutable-tuple was updated from 0.4.5 to 0.4.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

immutable-tuple is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 6 commits.

• b398c68 Add Node.js 10 to Travis CI rotation.
• f39d4c7 Bump npm version to 0.4.6 in preparation for publishing.
• 3f71a7b Avoid direct Object.defineProperty calls in hot code.
• 45269a7 Eliminate the internal intern(array) function.
• 50a6cc6 Add a test of tuple creation performance with objects.
• 9ec4d75 Add a test of tuple creation performance with strings.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Cannot resolve fibers in optimism

WARNING in ./node_modules/optimism/lib/local.js

Module not found: Error: Can't resolve 'fibers' in '/Users/***/node_modules/optimism/lib'
@ ./node_modules/optimism/lib/local.js
@ ./node_modules/optimism/lib/index.js
@ ./node_modules/apollo-cache-inmemory/lib/optimism.js
@ ./node_modules/apollo-cache-inmemory/lib/readFromStore.js
@ ./node_modules/apollo-cache-inmemory/lib/index.js

Add getKey & forgetKey API's to OptimisticWrapperFunction

Per the conversation in apollographql/apollo-feature-requests#289, add getKey & forgetKey API's to OptimisticWrapperFunction.

The motive here is to keep track of the cached entries without having to memoize the arguments and duplicate the logic for weakly tracking them. This will enable the creators of OptimisticWrapperFunction to use the true keys for removing entries via the forgetKey API.

Dependency keys are not cleared on LRU eviction

Looks like there is a minor "leak" in optimism even with LRU enabled: entries of depsByKey always stay in memory even after all optimism Entries corresponding to the given key are cleared.

So this key + an empty dep Set are "leaking":

optimism/src/dep.ts

Lines 31 to 35 in 4301eac

	let dep = depsByKey.get(key);
	if (!dep) {
	depsByKey.set(key, dep = new Set as Dep<TKey>);
	}
	parent.dependOn(dep);

In my testing it also survives Apollo eviction / GC, even cache.gc({ resetResultCache: true })

caches collides with the Browser API

In one of our projects we use @apollo/client wich itself includes this package. After bundling as ES module, there is a top-level variable caches that seems to collide with the one in the Browser's API.

So, using the optimism's ES module in a browser with type=module doesn't work. Is that the correct behaviour?

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

• engines was only updated if it defined a single version, not a range.
• .nvmrc was updated to Node.js 10
• .travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Documentation

This is an extremely popular node module, yet I have no idea what it does (beyond the one-line description), or how to use it. I think it might be what I need for a project based on this description, but it's very hard to tell given the lack of any information about it anywhere on the internet.

It seems to only have a few main functions that are widely used. Would it be possible for them to be documented?

An in-range update of immutable-tuple is breaking the build 🚨

The dependency immutable-tuple was updated from 0.4.9 to 0.4.10.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

immutable-tuple is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 2 commits.

• 485b323 Bump npm version to 0.4.10 in preparation for publishing.
• dff1503 Guard that Symbol.for is a function.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of rollup is breaking the build 🚨

The devDependency rollup was updated from 1.14.2 to 1.14.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Release Notes for v1.14.3

2019-06-06

Bug Fixes

• Generate correct external imports when importing from a directory that would be above the root of the current working directory (#2902)

Pull Requests

• #2902: Use browser relative path algorithm for chunks (@lukastaegert)

Commits

The new version differs by 4 commits.

• c68bd95 1.14.3
• d79aa57 Update changelog
• 7179390 Use browser relative path algorithm for chunks (#2902)
• b1df517 Add funding button

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of rollup is breaking the build 🚨

The devDependency rollup was updated from 1.9.0 to 1.9.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Release Notes for v1.9.1

2019-04-10

Bug Fixes

• Make sure inline comments in dynamic imports are preserved (#2797)

Pull Requests

• #2797: Emit inline comments inside dynamic import (@ndelangen)

Commits

The new version differs by 3 commits.

• 947067a 1.9.1
• d6935ba Update changelog
• 6709c17 Emit inline comments inside dynamic import (#2797)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴