ben-ng / add Goto Github PK

This module causes RangeErrors when used with package linear-algebra. Perhaps too many recursions?

Since add is being used for more accurate summations is there something similar which can or should be done for floating point multiplication? I'm not familiar enough with the number theory in this area to know the answer.

Even though #4 wasn't a massive performance improvement, being able to pass in parameters is more efficient when you have say 2 or 3 values you wish to add and they're not stored in an array. Because it saves having to construct an array.

And inside the add() function we can simply get everything as an array using arguments. If it doesn't impact performance I propose switching the function signature to use parameters. And also note that the upcoming ES6 function splats will make it easier to get a real Array from multiple function parameters.

not too familiar with the floating point precision gotchas, does subtract run into this problem as well?