bcoin-org / blgr Goto Github PK

The wrap function only deals with first two arguments of the original function's callback. This may not work properly for any function which give more than 2 args in their result callback like fs.read and fs.write. They produce 3 args in the result callbacks (err: NodeJS.ErrnoException, bytesRead: number, buffer: TBuffer)

https://github.com/bcoin-org/blgr/blob/master/lib/fs.js#L15

When passing loggers to other objects, it's sometimes useful to preserve the parent context name. For example, when running multiple nodes:

Currently:

With patch:

Patch used above (this is just an example, it can be made optional and custom separators, etc.):

diff --git a/old.js b/new.js
index 3d37a4c..bcbdc15 100644
--- a/old.js
+++ b/new.js
@@ -814,7 +814,7 @@ class LoggerContext {
    */
 
   context(module) {
-    return new LoggerContext(this.logger, module);
+    return new LoggerContext(this.logger, this.module + ':' + module);
   }
 
   /**

This package could use a new release since #5 was merged in. I am having trouble remotely helping users debug their issues and adding the stacktrace for logger.error would be very useful for this.