swift_library with objc_library deps about rules_apple

[lswith]

An Example would be:

# In an External Workspace @Hello
objc_library(
    name = "Hello",
    srcs = glob([
        "Hello/*.m",
    ]),
    hdrs = glob([
        "Hello.*.h",
    ]),
)

# In My Current Workspace
swift_library(
     name = "GoodBye",
     srcs = glob([
          "GoodBye/*.swift",
     ]),
     module_name = "GoodBye",
     deps = [
         "@Hello//:Hello",
      ],
)

If in GoodBye I try to import Hello it will fail. The module name is actually Hello_Hello.

[dmishe]

This is correct, though not well documented. Module names, by default, are full target labels with any non [a-zA-Z0-9] character replaced with "_". That is how @Hello//:Hello gets translated into Hello_Hello

[lswith]

can we add the ability to define a module name for these objects?

[dmishe]

For swift_library, you can set your own module_name. For objc_library, not yet, that would be a feature request on Bazel itself.

[lswith]

This is causing bugs with importing. An example would be this:
Hello/BUILD

objc_library(
    name = "Hello",
    srcs = ["Hello.m"],
    hdrs = ["Hello.h"],
    deps = [
        "@Goodbye//:Goodbye",
    ],
)

Goodbye/BUILD

swift_library(
    name = "Goodbye",
    srcs = ["Goodbye.swift"],
    deps = [ 
        ":Goodbye_objc",
    ],
   module_name = "Goodbye",
)

objc_library(
    name = "Goodbye_objc",
    srcs = ["Goodbye.m"],
    hdrs = ["Goodbye.h"],
)

This causes the bug inside the Hello module:

bazel-out/darwin_x86_64-fastbuild/genfiles/Goodbye/Goodbye-Swift.h:138:9: fatal error: module 'Goodbye_Goodbye_objc' not found
@import Goodbye_Goodbye_objc;
 ~~~~~~~^~~~~~~~~~~~~~~~~~~

[lswith]

any updates on this?

[dmishe]

lswith, could you paste the contents of Goodbye-Swift.h?

[lswith]

I decided to recreate the test again with the latest commits and it seems to be working from the hello folder. The Goodbye folder however, doesn't compile. https://github.com/lswith/bazel-ios-test

[ob]

I think this was fixed by #5905 and it can be closed.