AKA null in search results about avaa

[retokromer]

+1

[ablwr]

Oh gosh I saw this the other day and meant to put in a ticket for it! Thank you! I can do this (unless someone else wants to).

[kfrn]

Happy to do it! In the next few days okay?

[ablwr]

This will be fixed in 404search.js ... but should be fixed in both. But I also have a ticket out to consolidate both again which is also just a small tweak of the JS file. 404search just grabs the URL parameter instead of the one in the search box -- but there should really just be one JS file that grabs one-or-the-other depending on the page. Ticket #43!

[ablwr]

@kfrn Sure! If I beat you, I beat you. If you beat me, you beat me. AVAA wins!

[kfrn]

Oh, I failed to notice the 404search file & the other ticket.
In fact, couldn't it be solved (the display issue) by adding a conditional for namevar in the search page template: https://github.com/bavc/avaa/blob/master/search.html ?

[ablwr]

Oh yeah I think I remember it being in the template logic and not the .js logic!

[kfrn]

Tried fiddling with the template, it didn't really seem to do the trick, although I may not have properly understood the templating. Anyway, it's working nicely with the edit to the search.js file.

[ablwr]

closed via #74