basshelal / unsplashphotopicker

📷 Android Library providing a photo picker to search and download photos from Unsplash

Bassam Helal

unsplashphotopicker's Issues

Add SharedElementTransitions to photos when going to and leaving `PhotoShowFragment` like what Google Photos does

Add those smooth shared element transitions to make it seem like the photo is coming up from the picker and not just magically appearing

Add callbacks for errors / error states

Basically when the RecyclerView will be empty we need a way to allow for a callback that will allow us to do something when something goes wrong.
I can think of 3 error states:

• No results (Search returned no results)
• No connection (Internet connection error)
• Generic error (Something else)

We mainly want this so that the caller can add Views/Layouts to display when one of these happens and callbacks too to maybe act accordingly as well.

Add quick way to show the UnsplashPhotoPicker without xml

Something like UnsplashPhotoPicker.show(...) would be ideal and maybe also UnsplashPhotoPicker.get(...).

show will show the picker in a Fragment and get will return a View that you can add into your ViewGroups in code.

Make the photo be draggable when viewing it in `PhotoShowFragment` like what Google Photos does

So the user can drag it up and down to move it vertically and after a certain threshold it will dismiss

Add Proguard rules for models to prevent NullPointerException

I'm recieving Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'char java.lang.String.charAt(int)' on a null object reference inside UnplashPickerAdapter.onBindViewHolder() with minifyEnabled true.

Solution:

-keep class com.github.basshelal.unsplashpicker.data* {*;}
-keepclassmembers class com.github.basshelal.unsplashpicker.data* {
    <fields>;
    <init>();
    <methods>;
}

Unsplash API Endpoint calls return null values on some parameters

I'm not sure where this is exactly, but the calls seem to be returning null for some parameters consistently, like there's a pattern.

For an UnsplashPhoto its urls will always have medium == null and large == null

This needs investigation because the backend code is so goddamn unnecessarily confusing for now reason!

Remove unnecessary abstractions

Remove all the unnecessary classes and files and simplify backend code into fewer entities because currently it's a maze of classes and files that get called only once!

Add backend tests

Add unit tests for backend code

Determine and notify if an `UnsplashPhoto` is Sponsored

Unsplash has (recently?) added Sponsored photos. This isn't part of the official API (yet?) but there is a way to find out if an image is sponsored or not so we should use this to determine and show if a photo is sponsored

Separate Endpoint Calls into new API / Library