Coder Social home page Coder Social logo

xct_plus_wotlk's People

Contributors

alkotronikk avatar barsoomx avatar merfinx avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

ayaro1 merfinq alkotronikk milance2020 romanstrilchuk

xct_plus_wotlk's Issues

Show totem damage in outgoing damage output.

Is your feature request related to a problem? Please describe.
My fire totems do not show outgoing damage (Magma, Searing nor Fire Elemental).

Describe the solution you'd like
Fire totems' damage output should be shown in a same manner as pet damage.

Error on /xct

Describe the bug
An error pops up on /xct or option open and a blank window is shown. No other addon is selected

To Reproduce
Steps to reproduce the behavior:

  1. Disable all other addons
  2. Type /xct
  3. See error

Expected behavior
A window with options

Error Log

Message: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1836: AceConfigRegistry-3.0:ValidateOptionsTable(): xCT+.args.Frames.args.class.args.tracker.args.1,1.name: expected a string or funcref, got 'nil'
Time: 06/20/21 09:09:19
Count: 1
Stack: [C]: ?
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:50: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:45>
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:210: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:205>
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:244: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:219>
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:254: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:219>
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:254: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:219>
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:254: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:219>
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:254: in function <...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:219>
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:282: in function `ValidateOptionsTable'
...-3.0\AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:324: in function `app'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1836: in function `Open'
Interface\AddOns\xCT+\core.lua:1145: in function `ShowConfigTool'
Interface\AddOns\xCT+\core.lua:1130: in function `ToggleConfigTool'
Interface\AddOns\xCT+\core.lua:1114: in function `?'
...e\AddOns\xCT+\libs\AceConsole-3.0\AceConsole-3.0.lua:94: in function `value'
Interface\FrameXML\ChatFrame.lua:4070: in function `ChatEdit_ParseText'
Interface\FrameXML\ChatFrame.lua:3660: in function `ChatEdit_SendText'
Interface\FrameXML\ChatFrame.lua:3698: in function `ChatEdit_OnEnterPressed'
[string "*:OnEnterPressed"]:1: in function <[string "*:OnEnterPressed"]:1>

Locals: (*temporary) = "AceConfigRegistry-3.0:ValidateOptionsTable(): xCT+.args.Frames.args.class.args.tracker.args.1,1.name: expected a string or funcref, got 'nil'"

[Hunter] Explosive trap is missing an icon.

The Explosive Trap is missing an icon - both the instant component and the aoe over the time component.

The icon should be taken either from the spell itself or the physical (red border) debuff of the effect on targets.

let me know if I can help with debugging.

Merge Volley dmg for hunters.

I'd like to see Volley damage being merged. I already managed to merge it by adding a following line into the hunter section of merge.lua:

  [58433]  = CreateMergeSpellEntry("HUNTER", .5),      -- Volley

The 0.5 reasoning is that I can see each tick separately.

Healing Stream Totem in incoming healing

Describe the bug
Healing stream totem shows the totem's name instead of healer's name in the incoming heals.

To Reproduce

  • As a shaman place down healing stream totem
  • As a non-shaman have a shaman in your party place down healing stream totem
  • "Healing Stream Totem" with rank is displayed as a caster's name.

Expected behavior
A healer's name should be shown instead of totem name (the totem's owner/caster).

Blood Rune cooldown

Describe the bug
If Blood tap is used when Blood Runes are on cooldown, a LUA error will appear.
Also if Death Runes come off cooldown, the same LUA error will appear.

To Reproduce
Steps to reproduce the behavior:

  1. All addons disabled
  2. Keep Blood Runes on cooldown.
  3. Use Blood tap
  4. See error

Expected behavior
Shouldn't appear a LUA error.

Error Log

Message: Interface\AddOns\xCT+\modules\combattext.lua:872: bad argument #3 to 'sformat' (string expected, got nil)
Time: 07/25/21 16:48:03
Count: 10
Stack: [C]: ?
Interface\AddOns\xCT+\modules\combattext.lua:872: in function `?'
Interface\AddOns\xCT+\modules\combattext.lua:335: in function <Interface\AddOns\xCT+\modules\combattext.lua:317>

Locals: (*temporary) = "%s +%s %s"
(*temporary) = ""
(*temporary) = nil
(*temporary) = ""
(*temporary) = "string expected, got nil"

Adding Icon for incoming dmg

Is your feature request related to a problem? Please describe.
without icon in dmg taken we cant know what hit us
Describe the solution you'd like
display icon on incoming dmg and incoming healing please :D

Thank you very much

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.