barrykooij / wp-notification-center Goto Github PK

Some plugins use notice like this <div id="message" class="error"> where id is defined first and this plugin fails to pass regexp :)

Derived of this conversation on Twitter, how about a generated sample notification after the plugin has been activated for the first time? Something light and encouraging, will gladly help out with copy if you like the idea.

In addition to admin_notices, plugins can also use the following hooks for notices:

• network_admin_notices
• user_admin_notices
• all_admin_notices

It seems you've included the master branch from the wp-update-php repo. This version is out of date and now wp-notification-center causes conflicts with plugins that use the more recent version of wp-update-php.

You should include the release-1-1-0 branch instead.

The notifications I run into in the wild are quite often more than a few words, more like a few sentences at least. It looks like the default admin bar styling doesn't play well with that, causing the text to push off screen rather than wrapping:

Having fun with this I noticed HTML (line breaks, links) get stripped out of the notice text.
Bug or feature?

There seems to be a neat overlay of the name and the header text on the .org repo.

http://beil.io/11oBs

May be a great idea to move the notices up 30px :).

I am getting an "Notice: Indirect modification of overloaded element of WP_Hook has no effect in /home/kensin93/staging/app/plugins/wp-notification-center/src/AdminNoticeHandler.php on line 97" error and the plugin now no longer hides notifications

https://i.imgur.com/DGmCH8w.jpg

Wordpress 4.7.4 - running WooCommerce

Currently notifications within the manager only get a colored border when updated, update-nag or error are applied as classes. There are more notification classes in WordPress, though, that should be supported as well:

.notice-success,
div.updated {
    border-color: #7ad03a;
}

.notice-warning {
    border-color: #ffba00;
}

.notice-error,
div.error {
    border-color: #dd3d36;
}

.notice-info {
    border-color: #00a0d2;
}

https://github.com/WordPress/WordPress/blob/f446d01b4cb523015ced5e2660c40a46aeadb1e2/wp-admin/css/common.css#L1339-L1355

I get a fatal error on the front-end only. Things seem to work fine in admin area. I've added a screenshot from the front-end.

I have this issue with 2 different sites (both in local development)

Plugin version: 1.0.1
WordPress: 4.5.3
Way of installing: via composer
PHP version: 5.5+ (tried 5.5, 5.6 and 7)

If you need more info, you know where to find me

See #2