barrykn / android-cm7-bkndh1 Goto Github PK

When the Defy is turned off (say, from the battery running down to zero) and plugged in, it starts charging without fully booting. I guess that's tolerable [and it could be vitally necessary on a sub-1.0A charger, but my user exclusively uses an iPad charger so that's not an issue].

Once it reaches 100%, it just sits there without turning on. Then we can't call my user. Since I can't magically teleport myself to the phone's location to turn it back on, that's a problem. I need to fix this (or at least hack my way around it) if I can.

Earlier, I wasn't sure I wanted to file an issue over what I thought was a pipe dream. However, I have a couple ideas for actually implementing this now...

This is driven by the same concerns about the original Defy as issue #4. The main reasons I might consider adding support for the Dart are that I happen to have one, I think I should still be able to obtain them pretty easily, and the Dart I have actually doesn't seem too bad based on my experience with it so far (once I replaced the stock software with CM7.2).

My main concern right now is being able to get the button backlight(s) to light up, but even if I can't manage that, it might not be a showstopper.

My Motorola Defy phones have been dying like flies lately. They're breaking often enough that I need to move to a different kind of phone for this project.

Eventually, that's going to mean I need to redo my changes on top of Jelly Bean, but I also need to have other hardware for Gingerbread in case my user ends up being unable to adjust to Jelly Bean, or in case her current Defy breaks very soon.

For now, I should at least add support for the Motorola Defy+. It's more recent than the original Defy, and if Amazon reviews are any indication, people are happier with the reliability. It's also similar enough to the original Defy that I don't think adjusting to it should cause any problems for my user.

https://jira.cyanogenmod.org/browse/CYAN-1602

This issue is for fixing this in CM7.2, since that's what I have running in production. I might file separate issues for CM10.x.

This is motivated by hardware availability/future-proofing concerns. It's obvious enough (IMO) that I won't be able to obtain Gingerbread-compatible hardware forever.

[X] indicates a modification that I no longer need to patch into the source code before building Jelly Bean. [?] indicates a modification which may or may not need to be applied to Jelly Bean source -- I'll have to figure this out. (More specifically, it means I have a patch, but just because I can do it doesn't necessarily mean I should.)

(CM10.1 has not been officially released as of this writing. For the rest of this issue description, CM10.1 refers to the CM10.1 source code as it currently exists on the cm-10.1 branch.)

Going through the changes one by one:

[X] 2waysup volume button hack: I created a shell script that applies this mod; I can run this script after I flash a phone. I created the script for Gingerbread but I believe it should work with no changes on Jelly Bean.

android_frameworks_base:
[X] Global Actions dialog (over)simplification: This can be done from CM10.0/10.1 settings. The 1500ms power button timeout may also render this unnecessary. So I have nothing to worry about here. (Well, I may possibly have to worry if I go with ICS/CM9 instead of JB, but that's outside the scope of this issue.)

[X] 1500ms long press timeout: ICS and later have an Accessibility setting that does this already.

1500ms power key timeout: I've forward-ported this patch to CM10.1, and it should be trivial to port to anything between CM7.2 and 10.1. It's a straight, literal forward port, so it just hard-codes the timeout like the Gingerbread version of the patch. Perhaps that's not the most elegant way to go, but for now it'll get the job done.

[?] Make Quick Contact Badges play dead: I'm not completely sure how this will affect the Jelly Bean experience, so maybe I shouldn't apply this change. However, I have ported it forward.

android_packages_apps_Contacts:
I had originally checked out the wrong branch of CyanogenMod/android_packages_apps_Contacts, so it's no wonder that all my Gingerbread patches applied cleanly! I'll add another comment to this issue once I figure things out for real.

(NOTE: This is my first time filing a bug against my own project. This isn't really a bug report or even a general issue as much as a bunch of stuff I need to put into writing, so expect rambling and incoherence here. Sorry.)

So many small but vitally important changes over so many different repos... I need to look over it all and list all of my hacks in one place, so I have a relatively concise overview. (I should have been filing bugs against my own project all along, but at least I'm starting to do that now.)

Also, I need to figure out what I need to get changed (more cleanly of course) upstream (either CyanogenMod or AOSP). That's sufficiently related to this list that I guess I'll stuff it into this bug.

2waysup volume button hack: Almost certainly nothing here that should go upstream.

Contacts app hacking: Right now I think this is incomplete, I'll revisit the question after this stabilizes more.

3 things in android_frameworks_base:

1. Global Actions dialog (over)simplification: I think there are enhancements in CM10.0 that effectively implement this the right way. Looking at that in more detail will have to wait for later, though.
2. 1500ms long press timeout. This was actually inspired by Android 4.0, so nothing here is suitable for upstream. (Unless I want to do a proper backport of the Android 4.0 long press preference and submit it for a future CyanogenMod 7 release, but that's a low priority right now.)
3. 1500ms long press timeout on Global Actions (Power) key: I dearly want to see a pref for this in a future Android release. I'll look into filing a feature request (or whatever) for AOSP (and at that time I'll explain why this is necessary).

Finally, regarding changing the default baseband (this is a Defy-specific quirk, essentially): What I've been doing instead is to initially skip installation of the Google apps, change the baseband and/or set up WiFi, then install the Google apps, log in, etc.

Issue #1 is a mess, and I think a CHANGES file is what I really need. So, I need to write one.

I'm going to file a separate issue for Jelly Bean CHANGES.

After watching my user in action recently, I'm more convinced than ever that I absolutely must pare the UI down as much as I can. So, I need to remove the search buttons from both the All Contacts view of People and from the Call Log view of Phone.

This only affects CM10.1, not 7.2.

This is the one modification in my ROM that keeps me from using it for my own daily use, and I can easily write a shell script or something to add this hack to my user's phone after flashing it.

(The following comment is less precise than I'd normally like, but it's good enough that later on I'll know what I meant.)

Quarx2k's battd, if it works on Gingerbread, would let me use Defy+ batteries in the original Defy. All of my BF5X batteries are either bulging or have reduced capacity, so if I'm unable to move to (e.g.) the Defy+, then at least being able to use HF5X batteries would help.

I think the relevant commit is Quarx2k/proprietary_vendor_motorola@1f3696c.

BTW, another approach would be to just use the Defy+ battd on the Defy and just avoid combining BF5X batteries and my ROM. This is not the most urgent thing right now so I could come back to this later and figure out which approach would be better.

Just like issue #12, but for Jelly Bean (particularly CM 10.1).

I just got to see this today. I don't know how long will be long enough. :(

In the call log, tapping a call (to bring up call detail) shows options for adding a new contact and for sending SMS. I may need to remove the new contact button. I absolutely need to remove the SMS button.

This affects both CM7.2 and 10.1.