barrust / c-utils Goto Github PK

It would be beneficial to add a few more functions:

• s_find_*_alt()
  • Would include a "position" of the delimiter, like the second, etc. and return the point to that version
• s_find_*_cnt()
  • Would cnt the number of times the delimiter is found in the string

Now that it is (almost) possible to add vertices by id, it would be easier to allow for parallel generation of the graph with OpenMP support. There are a few considerations including using atomic builtins (gcc) for increments and decrements.

The only thing that needs the math library (-lm) is the ceil function for bitarray. It would be nice if that requirement were removed.

It would be nice if tests could be run on a windows machine; until travis.ci has better windows support, this may be difficult. Until then, another CI host may be needed. I figure there are issues (readdir, _rmdir, _mkdir, etc) will need to be resolved or thought through,

Some thoughts:

• int not equal
• int between
• int greater than
• int less than
• double between
• double greater than
• double less than

Move from Travis-ci to github actions

There are several places in the fileutils library that are not fully tested because they require symlinks, these should be tested in full as much as possible!

Need a function to get and set the permissions of a filepath as a mode_t

int fs_get_permissions(const char* path);
int fs_set_permissions(const char* path, int new_permissions);

Currently c-utils does not support removing a directory. There are several different removal types that will need to be handled:

• Single level, empty
• Single level, not empty (remove those files in the directory?)
• Recursive
  • files
  • no files

Some set of functionality should be supported!

Currently, each vertex is assigned an id so that it can be looked up in O(1) time. This makes using this library in parallel difficult as they may not be in the same order as they are from the source. Adding an alternate method of insertion that allows for the id to be passed in would help in making this library closer to thread safe (OpenMP).

Adding an automatic test for all new code pushed would help ensure everything is working as expected. This could also allow us to test windows environments.

An error occurs when using the fs_resolve_path function on a filename within the same directory:

fs_resolve_path("./somefile.txt");  // works
fs_resolve_path("somefile.txt");    // segfaults

It seems that we need to check for a -1 result for the first delimiter before jumping into the while loop.

Add a new function that checks and sets the bit to allow for simpler check and set operations.

There are many places that the doubly linked list could be simplified and reuse code; this cleanup will make it easier to read and maintain.

• fs_make_path() - combine into a single path
• add full path to the file_t object
• fs_list_dir() - return all the things

Add a linked list library and, perhaps, a doubly linked list library

Adding some examples to the code base could make it easier for others to get started with the project.