baltimorecounty / bcpl-assets Goto Github PK

• Talk to Michael Stevens about this

Specifically on this page

https://catalog.bcpl.lib.md.us/polaris/Search/titlelist.aspx

Load next 10 events a three times, then just after Wednesday, April 25, Comes Wednesday, December 31, 1969 and under the clock it says “bad start time” When I click on the link to the program, it’s a week long thing. Proably messing with the programming code?

https://staging.bcpl.info/events-and-programs/list.html#!/?term=bcreads

Site executive version opens up a modal when clicked and shows a menu when hovered. Polaris' version only shows menu when clicked and no modal

I think we may be able to simplify the animation when filtering. This also might help smooth the transition slighlty.

https://docs.angularjs.org/api/ng/directive/ngRepeat#animations

One link on the databases page isn't actually linking when clicked. Right clicking works though: https://www.bcpl.info/books-and-more/databases.html -- it's the New York Times item.

This is the only item that links to an internal SE page, which I just had to set up for a validation workaround.

Compare:

• https://www.bcpl.info/
• https://catalog.bcpl.lib.md.us/polaris/

Line 8 -
Condition 'date === 'Invalid Date'' is always false at this point because the else branch of the condition 'typeof date !== 'object'' at line 8 has been taken.

See: https://deepscan.io/dashboard/#view=project&pid=2129&bid=10806&subview=issues

Solution:
remove date === 'Invalid Date'

Example Id: 149072

Both date and time show up invalid.

BCPL homepage in staging renders the tablet-size layout on iPhone7.

On my personal computer I am getting issues with the tests.

• Libanswers error is causing one test to fail
• Moment is causing the another test to fail

I think in both cases the site is fine.

FYI @mxsnyder @danfox01

If someone were to load the page https://bcpl.info/books-and-more/databases.html you get cross domain issues

https://deepscan.io/dashboard/#view=project&pid=2129&bid=10806&subview=issues

Solution:

const addFilterId = (filterFamily) => {
  const newFamily = filterFamily;
  
  if (newFamily) {
    newFamily.name = newFamily.name === 'none' ? 
    	$scope.familyNameOverride : 
        newFamily.name;
    newFamily.filterId = newFamily.name.replace(/[^\w]/g, '-');
  }
  return newFamily;
};

Is it possible to limit the length on these in any way? Even if it's just a hard stop after a certain number of characters it would be better then some of these...

https://catalog.bcpl.lib.md.us/polaris/search/searchresults.aspx?ctx=1.1033.0.0.6&type=Keyword&term=Flying%20Lessons%20%26%20Other%20Stories&by=KW&sort=MP&limit=TOM=aeb&query=&page=0&searchid=17

Try https://www.bcpl.info/events-and-programs/list.html?ageGroups=Baby%20(0%20to%2023%20months)

https://deepscan.io/dashboard/#view=project&pid=2129&bid=10806&subview=issues&impact=%5B%22Low%22%5D&page=1

As found by Heather during testing.
"It works, but it's finicky with where you place your finger"

Currently, book covers displayed in a grid become misalinged and inconsistent when the covers aren't all the same size. Need a way to ensure grids look more consistently griddy.

Example: https://www.bcpl.info/blog/2018/new-next-week

https://www.bcpl.info/services/cant-find-it.html

This probably shouldn't fade, and is a side effect of the navigation animation.

Example https://www.bcpl.info/events-and-programs/list.html#!/151424

&nbsp is visible and that is not intended

Logo is still an image and causes the header section to be too large on mobile devices.

https://deepscan.io/dashboard/#view=project&pid=2129&bid=10806&subview=issues&impact=%5B%22Medium%22%5D&page=1

https://www.bcpl.info/blog

button on the left is hidden on smaller devices, but this is not the intended behavior

Privacy Policy and User Terms links are reversed in site.master.

May be related to the logo issue? It's a minor bug but very noticeable.

Compare the Polaris Search Tabs for the proper markup

Back button
https://catalog.bcpl.lib.md.us/polaris/message.aspx?ctx=1.1033.0.0.6

This should just return the user to the databases page.

It would be nice if the day of the week was included with the date in the table that displays below the description of the event.

Specifically on my iPhone 7, landscape renders polaris in a two-column view more suitable for tablet then phone.

ReferenceError: springSpace is not defined @
api2.libanswers.com/js2.18.5/LibAnswers_widget.min.js:3

It does not appear to have any side effects, but should be resolved.

@danfox01 FYI

The collapse and expanding of filters only happens on page load, we ultimately want this to happen with any browser action (back, forward, page load).

FYI @danfox01

Steps to recreate

1. Go to the events filter page
2. Select a event
3. See the footer in you face

If you open the search and then hover over a nav item, the search gets clobbered.

This is a placeholder, since it's not a bug with baltimore county code.

Basically the user has no clue that something is happenign when for example you type in a keyword on a mobile device.

Should be able to just copy this form the site executive instance.

To recreate open up the mobile menu from the catalog. Looks like the link is relative '/books-and-more/downloadables.html' but needs to point back to www.bcpl.info

Sam and I both registed and didn't receive one.

https://www.bcpl.info/events-and-programs/list.html#!/151424

site-search.spec.js

'should try to set the location to the catalog URL with a search term'

If you look at the footer on the site executive side the will appear on the left, but they are on the right in polaris.