Coder Social home page Coder Social logo

Comments (4)

bakkeby avatar bakkeby commented on May 27, 2024 1

Having given it a bit more thought I don't see how the highlighted parts of the match adds any relevant information to the table when the item anyway has been selected for output. I'll consider including the above.

from dmenu-flexipatch.

bakkeby avatar bakkeby commented on May 27, 2024 1

Pushed the above, let me know if you experience any issues.

from dmenu-flexipatch.

bakkeby avatar bakkeby commented on May 27, 2024

This seems intentional. It highlights the matching string which in this case (st) covers the entire item.

Should be fairly easy to address though, e.g. by simply not drawing the highlights if the item has been marked for output.

diff --git a/patch/highlight.c b/patch/highlight.c
index b5947b5..664a8b6 100644
--- a/patch/highlight.c
+++ b/patch/highlight.c
@@ -15,6 +15,14 @@ drawhighlights(struct item *item, int x, int y, int maxw)
        char *itemtext = item->text;
        #endif // EMOJI_HIGHLIGHT_PATCH | TSV_PATCH

+       #if MULTI_SELECTION_PATCH
+       if (issel(item->id))
+               return;
+       #else
+       if (item->out)
+               return;
+       #endif // MULTI_SELECTION_PATCH
+
        drw_setscheme(drw, scheme[item == sel ? SchemeSelHighlight : SchemeNormHighlight]);
        strcpy(tokens, text);
        for (token = strtok(tokens, " "); token; token = strtok(NULL, " ")) {

Applies for the fuzzyhighlight patch as well.

from dmenu-flexipatch.

62832 avatar 62832 commented on May 27, 2024

No issues here. Thanks a ton!

from dmenu-flexipatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.