baileysnyder / japanese-conjugation Goto Github PK

Could you add a license, e.g., BSD, GPL, to this project? My employer does not allow contributing to unlicensed software.

Please add instructions to run this locally.

This idea came up in a discussion on issue #17 by @krzysztof-krzeszowski

Right now, question probabilities are wiped when any settings within the Verbs or Adjectives sections are changed. All that persists is any question you may have missed in the last 2 rounds, if you're new settings happen to also contain those questions.

The downside to the current approach is possibly seeing duplicate questions more often because the app doesn't remember that you've already seen them. One thing to consider if this change is made is that it will give "Max Streak" values less meaning, because each group of settings will not be its own separate environment. Instead your actions within one group of settings will affect question probabilities in other groups of settings.

Instead of flagging answers with bad kanas as incorrect, could the app show an error dialog or similar? These happen when making typos and something that Wanikani does as well. An example:

For example, when trying to input つまらない through IME, the first suggested variant seems to be 詰まらない rather than 詰らない. It would be nice if both could be accepted as correct.

Sometimes answers using kanji are considered incorrect even if they are equivalent to the furigana answer. An example of this is 合わなかった is incorrect for 会う in the negative past improper.

I'm pretty sure not linking to the source code from the site itself is a violation of the gpl?

To find the source code I had to edit the url to go to the root of the site, then follow the github link, then find the correct project.

Allow for an option to hide the definition of the word, so instead of 難しい and then the word difficult below it just show the kanji

Now I have only recently studied this so I might be wrong but this app does not accept ないです and なかったです endings for negative past polite conjugations of うーVerbs.

Has any thought been put into adding other conjugation forms to the web app, like potential form, 〜たい form, and so on?

Instead of showing only one of the possible answers, show all of them.

Ie.
美味しい conjugated to negative past polite

美味しくなかったです
美味しくありませんでした

I find the app is really useful for practice, especially at beginner level, but I also find myself spending as much, if not more, time trying to parse the current conjugation requirements in any given task as I spend actually conjugating the verb, because the order (temporal - affirmative - polite) feels unnatural for whatever reason. Other person that I recommended the app expressed the same thing independently, so it might be worth thinking about.

A way to change the order in the settings would solve it nicely.

Could you add an option to limit verbs to JLPT levels, e.g., N4? Conjugating irregular verbs for upper levels is difficult.

I don’t know common formats, but something to take from like anki or other places and be able to select what you want to train. Will likely look at this myself in a bit and propose a solution (writing a converter function for common types / creating config to select which sets to drill).

(Side note: amazing project, thanks for building it)

Edge:

Chrome:

Firefox:

I think Edge looks the best. Might need to completely replace <ruby> and <rt> tags with spans since they don't seem to allow margin/padding CSS in most browsers.

First of all, thanks a bunch for the great tool, it's helped me tons already and I'm here because I hope I can help making it help even more. And that's a lot of helps but that'll have to do, lunch break is over :D

It is my understanding that the -tai form acts for (almost ?) all intents and purposes as a conjugation much like the supported ones, therefore I propose to add it to the supported conjugations.

From what I know and understand it seems to be that it should be relatively easy to implement, but as I'm far from being an accomplished JS developper I figured I might as well open anissue and check with you before jumping head first into a wall and giving up.

Am I correct when I say such a change would require the following changes to main.js :

• updating all xxConjugation methods with a complete else if (tense == "tai") clause ;
• add a matching case to conjugationFunctions ;
• add something in the past/present affirmative/negative loop here for the additional conjugations to be added to the array

The following change to optionfunctions.js :

• a verbtai clause in verbs to the optionRemoveFunctions constant that returns isNotTense(x, "tai-form")

And inserting a similar line below line 87 in index.html : <tr><td><input id="verbtai-checkbox" type="checkbox" name="verbtai"><label for="verbtai-checkbox">-tai form</label></td></tr>

In addition to matching changes I frankly have no idea about as of yet to style.css ?

First of all thank you for an amazing tool :) I'd like to suggest an option to turn on furigana and/or translation when one makes a mistake given furigana and/or translation is set to be not shown during the quiz. In this way one can not only learn the conjugation but also learn the reading and translation of verbs and adjectives.