baijunjie / jquery.animate Goto Github PK

Hello!

There is a issue with the "SlideDown" function. In the original JQuery behavior all styles get cleared after the animation has finished. In your Plugin the styles are still applied.

Original: https://jsfiddle.net/jfkrhz67/3/
Plugin: https://jsfiddle.net/jfkrhz67/4/
(check the console output)

I figured out this happens only if the target div is already slidedDown if you call the function. If you call "slideUp(0)" before, this bug doesnt seems to appear.

Please fix this anyway for the same behaviors between your plugin and original jquery.

Best regards,
Sora

Hi baijunjie, how can I contact you private?
Please remove that issue

Cant use $(element).slideToggle(500) with this lib.
This library is really cool, I'd like it to use it...

I hope you can fix this, because this function is really important! :)

Best regards,
Sora

Hello!

Your height calculation of the height which shall be applied on a "toggle" command (e.g. slideToggle) is slightly incorrect. You have to apply "display: block; overflow: hidden" style before you actually calculate the value.

I've fixed that like this in line 945:

old:

var inlineStyleValue = $self[0].style[p],
	originalValue = $self.css(p, '').css(p);
$self.css(p, inlineStyleValue);

new:

var isBox = (p === 'height' || p === 'width');
var inlineStyleValue = $self[0].style[p];
if(isBox)
	$self.css({ 'overflow' : 'hidden', 'display' : 'block' });

var originalValue = $self.css(p, '').css(p);

if(isBox)
	$self.css({ 'overflow' : '', 'display' : '' });
$self.css(p, inlineStyleValue);

Best regards,
Sora

Okay, there is another bug with $(element).stop().slideToggle().

Here is a test without your library (how it should look): https://jsfiddle.net/sgshLj9p/2/
And this is the case with your library: https://jsfiddle.net/sgshLj9p/1/

Hope you can fix this as fast as the last issue :)

Best regards!

Hello!

There is a issue with the css hook. If you specify in CSS your transform: "transform: translate(100%, 0)" and then read it "$().css('x')" it will write "0" but it should be "100%". If you set the value in JS the value is read correctly. Because of this issue animations doesnt work properly if you have such rules in your CSS.

Reproduction: https://jsfiddle.net/jfkrhz67/
(Please read the console.)

Please try your best to fix this as fast as possible :)

Best regards,
Sora

If the inProgresscould be called at a rate of fps 24 (for example) during animation, would be great!

This will open door to a new world!

Thanks a lot!