Comments (5)
@Anachron : I'd welcome a pull request for this feature... but it's unlikely that I'll have the time to implement it myself. Please let me know if you're interested in working on this.
from backbone.subroute.
@geekdave well did you take a look at that library? It's just 100 lines long and pretty self explaining 👍
from backbone.subroute.
@Anachron: Regardless of how many lines of code your feature would take to implement, there is time involved in writing tests, documenting, regression testing, etc.
It's generally poor form in the Open Source community to suggest that someone else should have the time to work on something that you, yourself are unwilling to spend time on doing yourself.
As I said, I would be happy to entertain this feature as a PR. If you're just not sure how to do it, you can find this project's PR requirements here: https://github.com/ModelN/backbone.subroute#pull-requests , and there are lots of guides out there on the interwebz for how to contribute a PR back to a project.
I'd be glad to help if you are unsure about anything in the PR process. But simply insisting that it's a small enough change that I should do it is not likely to get you very far. 😉
from backbone.subroute.
@geekdave well thanks for the kind words. Actually I'm pretty busy myself, maybe I will find some time to make a PR. Tests are a must, I can see?
from backbone.subroute.
@Anachron, I've merged these two projects already for my own use. It was a quick and dirty job, so the routefilter tests haven't been ported over, but maybe it'll save you a bit of time if you're still interested in this. I intend to complete the tests myself and submit a PR, but I won't have time for a couple months at least.
https://github.com/Pleochism/backbone.subroute
from backbone.subroute.
Related Issues (20)
- Routes with named params HOT 6
- How can I restart subroutes? HOT 2
- Suggestion: returning Backbone.navigate or at least returning "this" HOT 3
- Polluted Routes when using a common base router class HOT 5
- Problem with Backbone AMD HOT 3
- Minified version produces wrong route HOT 1
- Publish latest version to npm HOT 1
- Backbone and underscore should be dependencies (not devDependencies) HOT 1
- Route gets triggered twice HOT 3
- accessing router initialize parameters from the route callback? HOT 3
- using back button does not re-trigger all my routes
- loadUrl into uninitialized subroute fails HOT 3
- Seeking New Ownership! HOT 6
- Specify createTrailingSlashRoutes as an instance property when extending from Backbone.Subroute
- handling zombie views in the subroute
- Update bower info
- npm support
- Regex routes
- Multiple SubRoutes - is it possible?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backbone.subroute.