Polluted Routes when using a common base router class about backbone.subroute

[joshuaballoch]

@geekdave I created some tests to show what I mean (I've never used jasmine before, so apologies if they're not well written). I created them on a fork at https://github.com/joshuaballoch/backbone.subroute/blob/polluted-routes/spec/js/route-pollution-specs.js

I ran the tests; if you comment out the second test at https://github.com/joshuaballoch/backbone.subroute/blob/polluted-routes/spec/js/route-pollution-specs.js#L14 and just run https://github.com/joshuaballoch/backbone.subroute/blob/polluted-routes/spec/js/route-pollution-specs.js#L9, then you see the routes being initialized as expected.

Subsequently, if you run https://github.com/joshuaballoch/backbone.subroute/blob/polluted-routes/spec/js/route-pollution-specs.js#L14, you will perhaps see in more detail what I mean.

[geekdave]

Looks like this may be a regression caused by #22 caused by #16. I am looking into it.

In the meantime, to unblock yourself, you can use v0.3.2 which does not have this issue:
https://github.com/ModelN/backbone.subroute/blob/0.3.2/backbone.subroute.js

Note that in your test spec:

    var subRouter = Backbone.SubRoute.extend( {
        routes: {
            "":"handDefaultRoute"
        }
    } );

    it ( 'should have normal subroutes if just one subroute is initialized', function () {
        SubRouterOne = new subRouter("subrouterone");
        expect(SubRouterOne.routes).toEqual( { '' : 'handDefaultRoute', subrouterone : 'handDefaultRoute' } );
    } );

The it block should not expect { '' : 'handDefaultRoute', subrouterone : 'handDefaultRoute' } but rather { "subrouterone" : 'handDefaultRoute' }

This is because the default empty string route should get the prefix prepended to it.

[geekdave]

Specifically, this seems to be caused by some change in PR #23 PR #16.

EDIT: Mistakenly attributed the regression to the wrong change. Appears to be due to the switch to using dynamic runtime processing of prefixed routes, instead of constructing the routes only at initialization time.

[geekdave]

Fixed. Big thanks to @mikesnare for suggesting the fix, and for @joshuaballoch for providing the specs to identify the issue (merged in PR #28)

[geekdave]

Released version 0.4.1 with this fix (https://github.com/ModelN/backbone.subroute/releases/tag/0.4.1)