babak1368 / microservicesample Goto Github PK

There are a lot of blank lines and misaligned spaces in a lot of places. Again easy problem to overlook, but it's also easy to fix.

If I'm not mistaken. These functions (handlers) will be assigned to methods on the global object. Why not just use a const before the name of the handler?

This is not a RESTful API in my opinion. An actual RESTful HTTP API for this resource with your controllers would look like this:

router.get('/customer', customerController.listHandler); 
router.post('/customer', customerValidator.validateCreate, customerController.createHandler); 
router.patch('/customer', customerValidator.validateUpdate, customerController.updateHandler); 
router.delete('/customer', customerValidator.validateDelete, customerController.deleteHandler);

Why let? I mean these are small issues that can even be solved using static analysis of the code and they are in other places in the repo as well. I won't comment on all of them, but Eslint would have been able to catch these little mistakes and even fix them automatically.

Another example:

Would be nicer to have _ for the unused variable.