b-sides / elcimagepickercontroller

A clone of the UIImagePickerController using the Assets Library Framework allowing for multiple asset selection

ELCImagePickerController

A clone of the UIImagePickerController using the Assets Library Framework allowing for multiple asset selection.

Usage

The image picker is created and displayed in a very similar manner to the UIImagePickerController. The sample application shows its use. To display the controller you instantiate it and display it modally like so.

// Create the image picker
ELCImagePickerController *elcPicker = [[ELCImagePickerController alloc] initImagePicker];
elcPicker.maximumImagesCount = 4; //Set the maximum number of images to select, defaults to 4
elcPicker.returnsOriginalImage = NO; //Only return the fullScreenImage, not the fullResolutionImage
elcPicker.returnsImage = YES; //Return UIimage if YES. If NO, only return asset location information
elcPicker.onOrder = YES; //For multiple image selection, display and return selected order of images
elcPicker.imagePickerDelegate = self;

//Present modally
[self presentViewController:elcPicker animated:YES completion:nil];

// Release if not using ARC
[elcPicker release];

The ELCImagePickerController will return the select images back to the ELCImagePickerControllerDelegate. The delegate contains methods very similar to the UIImagePickerControllerDelegate. Instead of returning one dictionary representing a single image the controller sends back an array of similarly structured dictionaries. The two delegate methods are:

- (void)elcImagePickerController:(ELCImagePickerController *)picker didFinishPickingMediaWithInfo:(NSArray *)info;
- (void)elcImagePickerControllerDidCancel:(ELCImagePickerController *)picker;

The Image Picker allows for some customization, including limiting to just one photo album, limiting to single image selection, and automatically scrolling to the bottom. See the demo viewcontroller for example usage.

License

The MIT License

Copyright (c) 2010 ELC Technologies

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

elcimagepickercontroller's Issues

Infinite loop in init of Classes/ELCImagePicker/ELCImagePickerController.m in iOS 5.1

An init was added during the ARC conversion to Classes/ELCImagePicker/ELCImagePickerController.m.
In init, it messages [super initWithRootViewController], in 5.1, super calls init, causing the infinite loop.

In 6.1, it seems to call initWithNibName instead.

Not sure how to fix as just reverting the code will break the updated demo code

is there support for remote image url?

Super slow

On an album with over 200 pictures, the image selection view literally takes minutes to load. Any ideas?

Suchit

ELCAssetCell minor typo fix.

Hi

THere is a minor typo in ELCAssetCell.m I found. When I fixed this it really sped up scrolling performance of my 400+ pics library.

Attaching code. Attaching Code

Thanks

ELCImagePicker can load the network photos?

dear all,
how ELCImagePicker load and browse the network photos?

only get loading....

I tried your sample code on several iPhones and it's working only if there are not so many pictures stored on the device, once a folder has more then 200 images there is a delay and its shows loading for a few seconds.

However, I have one iPhone 4 with more then 800 images in several folders and it doesn't even go past the "loading" stage.

I have one app called " Stash Pro" (hedonic software) and they are able to open the photo library without any delay (even with 800 images) and you can import several pictures or even the complete folder.

Did they use a modified version of this script ? Or does anyone know how they made it ?

I saw several other users who have the same issue that the pictures are not loading.

ELCAssetTablePicker crash on Loading Images

On an iPhone 3G, try an album with 1000+ images and select an image before the "Loading..." message goes away.

Eventually it is going to crash in numbersForRow because assetGroup is not retained as it should be.

Multiselection between different albums

First of all, thank's for the library, it's a good job.
My question is: there is a way to permit multi selection between different albums? because when i change from album 1 to album 2 and then i return back to album 1, i lose the selection that i did the first time.
I want to select for example, 2 photos from the first album and then 3 from another one.
Thanks in advance.

Retina display problem

I'm using ELCImagePickerController for my application. This is great but compared to the original picker controller it seems that the image saved is not retina ready. I compared two images and the one from ELCImagePicker is a bit pixeled ...

Here's the code that is getting the UIImage :

for(ALAsset *asset in _assets) {

        NSMutableDictionary *workingDictionary = [[NSMutableDictionary alloc] init];
        [workingDictionary setObject:[asset valueForProperty:ALAssetPropertyType] forKey:@"UIImagePickerControllerMediaType"];
        [workingDictionary setObject:[UIImage imageWithCGImage:[[asset defaultRepresentation] fullScreenImage]] forKey:@"UIImagePickerControllerOriginalImage"];
        [workingDictionary setObject:[[asset valueForProperty:ALAssetPropertyURLs] valueForKey:[[[asset valueForProperty:ALAssetPropertyURLs] allKeys] objectAtIndex:0]] forKey:@"UIImagePickerControllerReferenceURL"];

        [returnArray addObject:workingDictionary];

        [workingDictionary release];    
    }

Do you know how can I do to correctly render my images (for retina) ? I tried to change - fullScreenImage property to - fullResolutionImage but the result is insanely huge (400 ko to 1 Mo for a photo). Thanks for your help !

not working in iOS5

When running in iOS5 the demo app shows empty lists.
There is an issue with the ALAssetsLibrary *library being releaed (too) early in - (void)viewDidLoad of ELCAlbumPickerController.m

Quick and dirty workaround is to remove the [library release] :)

Location not stored with ELCAsset

I am interested in the photo location, and ELCImagePickerController.m doesn't store the ALAssetPropertyLocation on the selected assets. I have added this behaviour on my branch, but it requires adding CoreLocation framework.

Before I submit a pull request, I was wondering if adding CoreLocation framework is a PITA for anyone. If it is undesirable for some, perhaps this behaviour should be ifdef'd in.

[ELCImagePickerController setMaximumImagesCount:]: unrecognized selector sent to instance

Hi,

I am using version 0.1.2 via cocoapods. When I run my app the following instance variable is crashing my app:

ELCAlbumPickerController *albumController = [[ELCAlbumPickerController alloc] init];
ELCImagePickerController *imagePicker = [[ELCImagePickerController alloc] initWithRootViewController:albumController];
[imagePicker setMaximumImagesCount:4];//crash here
[albumController setParent:imagePicker];
[imagePicker setDelegate:self];

// Present modally
[self presentViewController:imagePicker
                   animated:YES
                 completion:nil];

the following way is also not working:

imagePicker.maximumImagesCount = 4;//not working either

the iVar maximumImagesCount is there in ELCImagePickerController. So why the code is crashing?

Thanx.

iOS target = 5.1

Orientation issue on iOS5

Hi, I'm using your component for an iOS5 project and stumbled upon some orientation problems. Some images appeared to be upside down.

I saw in the commit log that you removed your orientation fix, probably because it wasn't working 100%. But I think I found the fix:

In ELCImagePickerController.m change:

[workingDictionary setObject:[UIImage imageWithCGImage:[[asset defaultRepresentation] fullScreenImage]] forKey:@"UIImagePickerControllerOriginalImage"];

with:

// Retrieve the image orientation from the ALAsset
UIImageOrientation orientation = UIImageOrientationUp;
NSNumber* orientationValue = [asset valueForProperty:@"ALAssetPropertyOrientation"];
if(orientationValue != nil) orientation = [orientationValue intValue];

[workingDictionary setObject:[UIImage imageWithCGImage:[[asset defaultRepresentation] fullResolutionImage] scale:1.0 orientation:orientation] forKey:@"UIImagePickerControllerOriginalImage"];

Crash when app is asking a permission to access photos, and Cancel to dismiss not working

When ELCImagePickerController is opened for a first time, it asks for a permission to access photos, and then it crashes. After you accept and compile for a second time, it does not crash.

Cancel to dismiss ELCImagePickerController is not working, I have set the delegate.

Not Working in Landscape mode

Hello Everyone,
My app is in landscape, and I can't get the ELCImagePicker to show up in Landscape View.
I managed to get the view itself in landscape mode but the photo tiles appear as they would on Portrait.
It only shows 4 images per row.
How do I fix this?
Thanks you so much in advance

the location of the first image

if there is no enough photo to fill the cell, the image will align center, I had seen the location in the cell's layoutsubview method but really not clear how to fix it like the system album shows align left, can you tell me?Thanks

Leaking

I seing a leak when I pick some photos and then get back (so I assume that not everything is deallocated). Here is the information about the leak:

Malloc 64 bytes #1 Size: 64bytes Responsible Library: UIKit Responsible Frame: GetContextStack
Malloc 16 bytes #1 Size: 16bytes Responsible Library: WebCore Responsible Frame: WebThreadCurrentContext

trouble

Function to write very well, but entrust writing is very poor, high coupling

video not shown in the picker

I'm running the demo, video in Camera Roll doesn't show up. Is it a bug or doesn't support video by intention as the name implies? if so, how to expand it to select video?

ELCImage picker not working on private app directories

Since ELCImage picker controller uses the assets library function, it is used for selecting multiple images only from the default camera roll. But in the camera apps in which we store our images in the private directory instead of the camera roll, we are not able to use ELC for the multi-select of the images.

ELCAssetTablePicker preparePhotos crash with Bad Exec

Hi,

i am trying to integrate your wonderful image picker in my application.
Everything works fine and the ELCAlbumPickerController let me pic an album.
But then i get a bad access exception when the ELCAssetTablePicker tries to enumerate the images of the selected assetGroup.
The call [self.assetGroup enumerateAssetsUsingBlock:^(...) in prepare Photos throws the exception.
I try to debug but everything seems to be ok. The assetGroup is not null.
I get this when i run it on an iOS 5.1 Simulater.
On the iphone iOS 4.3 Simulator the albums will not load.
He will not execute the code to laod the albums ansy with the dispatch_async call.

Do you have any suggestion for me?

Thanks and best regards

Images' path

hi

how do i get the image url to upload it .
[_chosenImages objectAtIndex:1]

thanks

EXC_BAD_ACCESS When select a photo album without photos

When I select a photo album without photos, "EXC_BAD_ACCESS" error appears in the following code in ELCAssetTablePicker.m

    [self.tableView scrollToRowAtIndexPath:[NSIndexPath indexPathForRow:ceil(assetGroup.numberOfAssets / 4.0)-1 inSection:0] atScrollPosition:UITableViewScrollPositionBottom animated:NO];

metadata

Is there a way to get an array of locations for the selected images ?

Because, uiimage strips any metadata

New tag for cocoapods

Hey, the latest version at cocoapods is a little old, could you guys create a new tag and send a new Podfile to Specs repo?

ImagePIcker crashes with "Assertion failure" message before navigation into Grid view

i'm getting following Assertion issue sometimes but its not comes in simulator.

2013-09-07 09:30:39.858 AppName[1329:6537] enumerating photos

2013-09-07 09:30:39.859 AppName[1329:6537] done enumerating photos

*** Assertion failure in -[UISectionRowData refreshWithSection:tableView:tableViewRowData:], /SourceCache/UIKit/UIKit-2372/UITableViewRowData.m:400

2013-09-07 09:30:39.866 AppName[1329:907] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Failed to allocate data stores for 2147483647 rows in section 0. Consider using fewer rows'

It allocates 2147483647 number of rows...

have problem allocating rows

(NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section
{

int rows = ceil([self.elcAssets count] / (float)self.columns); //it returns 2147483647 rows sometimes.

return rows;

}

anyone came across this? solution?

Update:

i found that ELCAssetTablePicker self.columns returns 0 sometimes.

This is how the value of columns assigned by default
self.columns = self.view.bounds.size.width / 80; //main screen size would fix this

i just modified that to self.columns = 4; now it works fine no issues. Is this the correct way to fix this issue?[this would affect orientation grid]

Thanks.

where to set ELCAssetPickerFilterDelegate ?

Hello,
I'm a little bit at loss as to how to set the ELCAssetPickerFilterDelegate ? it's defined in the ELCAlbumPickerController class, which instance is used as root view controller to the parent ELCImagePickerController... Is there a way to access ELCAlbumPickerController instance from the controller that launched ELCImagePickerController or is there a convenience function that allows access from ELCImagePickerController?

thank you
-M

Missing AssetsLibrary framework in Podspec

The pod may not be compiled if no other pods required the framework.

Album shows 0 photos

When I open the imagepicker it first shows photo library and camera roll. Both of these have a (0) next to them even though I know I have photos in there? Anything I'm doing wrong here?

Albums slow to load with large number of photos (+ solution)

I have some customers who have 10,000 images in their photo libraries on their devices and the image picker is very slow to open.

I noticed that an ELCAsset is created for each image in an album, each one contains 2 UIImageViews etc., are created on a non-main thread etc.

This is working against the whole point of having a UITableView reuse cells since it can create thousands of unused UIImageViews when we only ever see see a few dozen onscreen at any point.

By having the each ELCAssetCell own and create its own ELCAssets and then simply setting new images from the ALAssets as each cell is reused/configured the view will load instantly even when an album contains thousands of images and scrolling performance is unaffected. (since this is what UITableViewCell reuse was designed for)

Unfortunately, my code has diverged significantly (due to the nature of my app) so I cannot easily submit a patch but I wanted to help point others in the right direction.

Not working with iOS 7 Beta1

I know it is early, but it is not working with iOS 7 Beta 1.
The Album list shown fine, but no images are show after selecting one album.
The strange thing is, that you can click the images...
So if you click somewhere and the Done, one image is selected

On iPad (iOS 7 GM) with more than 500 pictures the last line of images not show correclty

Hi,

On iPad (iOS 7 GM) with more than 500 pictures on Camera Roll (542 to be exactly but it happens with less pictures or with more) on "Camera roll" the last line (the newer images) not appear correctly.
The last line have something like a "background" of other line of images. For example if you have two images on the last line you have behind the two images other older images from other row.

Steps to reproduce:
1- Open the example project on iPad (iOS 7 GM) with more than 500 pictures on Camera Roll.
2- Click on "Normal Picker"
3- Select the Album "Camera Roll"

Note: I attach an image with all the images real of the bottom two lines selected. The others images that are not selected are the "background" of images that should not appear.

Issues under ios 7

Hey,

The multiple selection was working great under iOS 6 but when we start working on the iOS 7 SDK we encountered the following problem:

• The 3rd party image picker opens and shows the available albums
  
• Tap on any album and see how it navigates to the album images, you get a glimpse of the images but a second later they disappear and you can’t select any.
  

Any help would be appreciated.
Thanks.

Change quality of uimage

It scale to minimum after selecting images and destroy the quality of images...please tell me how can i get those images in real quality....?

Thanks in advance

i have found two bugs for you code

i have found some bugs for this code;

1. in ELCAssetTablePicker, viewDidLoad
   [self performSelectorInBackground:@selector(preparePhotos) withObject:nil];
   you can not update UI in non-main thread.

-(void)preparePhotos {

NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];


NSLog(@"enumerating photos");
[self.assetGroup enumerateAssetsUsingBlock:^(ALAsset *result, NSUInteger index, BOOL *stop) 
 {         
     if(result == nil) 
     {
         return;
     }

//must updated in main thread
dispatch_async(dispatch_get_main_queue(), ^{
ELCAsset *elcAsset = [[[ELCAsset alloc] initWithAsset:result] autorelease];
[elcAsset setParent:self];
[self.elcAssets addObject:elcAsset];
});
}];

NSLog(@"done enumerating photos");

//move the follow code to view did load is much better;
dispatch_async(dispatch_get_main_queue(), ^{
[self.tableView reloadData];
[self.navigationItem setTitle:@"Pick Photos"];
}
[pool release];

}

1. the orientation is not correct in the delegate;
   i think you'd better change the delegate like this, just pass the ALAsset object to the invoker, do not pass original image, because it used too much memorey.

@protocol ELCImagePickerControllerDelegate

• (void)elcImagePickerController:(ELCImagePickerController *)picker didFinishPickingAssets:(NSArray *)assets;

@EnD

Crash when you select 30 images

My app is crashing when I clicked on save button. It's works fine for less images but when I elect over 30 images in iphone 5 and over 13 images in old iphone 4 it's crashes.

ARC errors

Not working when using ARC. I tried removing all dealloc and release but I'm still left with a bunch of linker errors.

Trouble in iOS 5 beta 6

In -[ELCAlbumPickerController viewDidLoad], removed the enclosing
dispatch_async(dispatch_get_main_queue(), ^
block.

-(void) viewDidLoad
{
[self.navigationItem setTitle:@"Loading..."];

UIBarButtonItem *cancelButton = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemCancel target:self.parent action:@selector(cancelImagePicker)];
[self.navigationItem setRightBarButtonItem:cancelButton];
[cancelButton release];

NSMutableArray *tempArray = [[NSMutableArray alloc] init];
self.assetGroups = tempArray;
[tempArray release];

ALAssetsLibrary *library = [[ALAssetsLibrary alloc] init];        
[library enumerateGroupsWithTypes:ALAssetsGroupAll 
                       usingBlock:^(ALAssetsGroup *group, BOOL *stop) {
                           if (group == nil) 
                           {
                               return;
                           }

                           [self.assetGroups addObject:group];

                           // Keep this line!  w/o it the asset count is broken for some reason.  Makes no sense
                           NSLog(@"count: %d", [group numberOfAssets]);

                           // Reload albums
                           [self performSelectorOnMainThread:@selector(reloadTableView) 
                                                  withObject:nil 
                                               waitUntilDone:YES];
                       }
                     failureBlock:^(NSError *error) {

                         UIAlertView * alert = [[UIAlertView alloc] initWithTitle:@"Error" 
                                                                          message:[NSString stringWithFormat:@"Album Error: %@", [error description]] 
                                                                         delegate:nil 
                                                                cancelButtonTitle:@"Ok" 
                                                                otherButtonTitles:nil];
                         [alert show];
                         [alert release];

                         NSLog(@"A problem occured %@", [error description]);                                   
                     }];

}

is it possible pick multiple videos using ELCImagePickerController?

I don't know whether it is the right place to ask this question. I want to pick multiple videos like images, is it possible with ELCImagePickerController?

Crash when selecting a photo from a shared photo stream

Exception: *** setObjectForKey: object cannot be nil (key: UIImagePickerControllerOriginalImage)

I have been getting this exception at the following line in ELCImagePickerController.m:

[workingDictionary setObject:img forKey:@"UIImagePickerControllerOriginalImage"];

It only occurs when I select a photo from a photo stream that someone else is sharing. Does anyone have any idea what is going on?

I tried this on a iPhone 5 and 5S with the same issue. It seems to work fine on the iPad though.

Overlay.png

It's required in ELCAssetCell but the demo project doesn't include it.

Large number of Images?

I notice that there is a problem with the component if you have a very large number of images (6000 images does it for me), the problem (if I understand it correctly) is that the component initializes all ELCAsset with a thumbnail and stores them in the elcAssets array. If you have for instance 6000 images the component crashes when you start scrolling to all these items.

Any suggestions how to fix this issue, been trying to play around with it for last few days but haven't really come up with any good solutions (that doesn't bring performance down or make it extra complicated with threads).

Sample project not loading photos on iOS 4.2.1

The navigation bar continues to say "Loading..." and it never retrieves the photos from the library. It works fine in the simulator.

Filter

Hello,

i tried to filter ELCpicker to show for example only today's photos, by using a simple IF method in asset.m when adding assets to the assetlibrary.

It worked for the photos, but it enumerated cells and checkmarks for the whole camera roll...So i can see for example 3 photos, but can select more ( which are invisible, but selectable).

Where should i put my filter code so that both photos, and table cell selectors are synced ?

The application crash fist time

The application crash fist time While asking for permission to open Camera roll.

Error is

Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Attempting to begin a modal transition from <ELCImagePickerController: 0x10c683f00> to <UINavigationController: 0x113308270> while a transition is already in progress. Wait for viewDidAppear/viewDidDisappear to know the current transition has completed'

Regards
Alok

PushViewController?

How to push it in navigationController instead of PresentViewController?

Crashed when selecting more than 100 images from photo library

When select more than 100 images then application got received memory warning and then it crashed.

Please let me know if you required anything regarding for the same.

elcassetcell crash

Hi guys,
Sweet image picker. Works great except SOMETIMES the app crashes when loading the images in my main album with error:
-[UIDeviceRGBColor countByEnumeratingWithState:objects:count:]: unrecognized selector sent to instance 0x588b5b0
The only thing i've done is clicked on the album that i want to browse.

It seems to happen if I click on the album immediately after the initial tableview appears. If I wait a second and then tap the album, it works fine.
I'm guessing it takes a while to initialize? I have about 200 images.

Thoughts?

Crash in [ELCAssetCell layoutSubviews]

Hello All,

Overall picker works great.But just occasionally it crashes with the following error.I would really appreciate if some one can help me resolve this issue.

Azeem

Error:
2011-11-02 16:39:18.261 distribution[606:701f] -[**NSCFType setFrame:]: unrecognized selector sent to instance 0x1e0940
2011-11-02 16:39:18.306 distribution[606:701f] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFType setFrame:]: unrecognized selector sent to instance 0x1e0940'
* Call stack at first throw:
(
0 CoreFoundation 0x3759dc7b __exceptionPreprocess + 114
1 libobjc.A.dylib 0x32d9bee8 objc_exception_throw + 40
2 CoreFoundation 0x3759f3e3 -[NSObject(NSObject) doesNotRecognizeSelector:] + 98
3 CoreFoundation 0x37544467 __forwarding + 506
4 CoreFoundation 0x37544220 _CF_forwarding_prep_0 + 48
5 distribution 0x0000dd0b -[ELCAssetCell layoutSubviews] + 250

selecting an image then unselecting it then clicking done calls wrong delegate

when I select and image and then deselect and click done it actually calls:

• (void)elcImagePickerController:(ELCImagePickerController *)picker didFinishPickingMediaWithInfo:(NSArray *)info

instead of:

• (void)elcImagePickerControllerDidCancel:(ELCImagePickerController *)picker