azzawie / ecommerce-site Goto Github PK

Overall not very much feedback to give! It mostly looks good.

I think the only feedback I have is that there is nowhere that the user is able to put in data about their ads. The purpose of the assignment was to have all the frontend completed. Please make sure you get that done as soon as possible because the next assignment is going to need these elements in there.

How is the user supposed to create or modify their ads?
https://github.com/MwMaki/CS412Final_Azzawie/blob/Homework/2021_06_30/CS412Final_Azzawie/BLL/Interfaces/IAdBLL.cs

Good job:
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/DAL/AdDAL.cs#L115

Would be easier if you switched it now:
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/Models/Ad.cs#L16

Misspelling:
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/Models/Address.cs#L17

Cool!
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/ContactUs.aspx.cs#L66

I thought here we were creating an ad? There doesn't seem to be any calls to the BLL to create it:
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/CreateAd.aspx.cs#L56

No call to the BLL to edit the ad:
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/EditAd.aspx.cs#L55

This shouldn't be hardcoded here anymore. It should be mocked in your DAL and retrieved through your BLL:
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/ShowAd.aspx.cs#L30

Lack of code:
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/ShowAd.aspx.cs#L55

This should no longer be hard coded, and should be getting data from the user's input:
https://github.com/MwMaki/CS412Final_Azzawie/blob/698eccac3ddda504caac46ec68d0ae6eb5e59be2/CS412Final_Azzawie/SignUp.aspx.cs#L114

Overall, good use of repeaters and such. I think there's some missing functionality that still needs to be coded though in order for the user to better interact with your website. By now, your website should be fully interactable by utilizing the mocked objects.

Good commenting!

If there are no errors, you really should be sending yourself an email with the information that the user submitted, not redirect to the homepage:
https://github.com/MwMaki/CS412Final_Azzawie/blob/d8eaaf82b71235f0a1908315f0c6aaabb6f843f3/CS412Final_Azzawie/ContactUs.aspx.cs#L57

Good effort, but this should be on the master page level as you don't want to be copying/pasting this code over and over onto every page:
https://github.com/MwMaki/CS412Final_Azzawie/blob/d8eaaf82b71235f0a1908315f0c6aaabb6f843f3/CS412Final_Azzawie/CreateAd.aspx.cs#L15

Whenever an ad is created, it should really be creating an ad AND redirecting it if you want. But it shouldn't just redirect to the homepage. You should have setup a model and loaded the data that the user inputted into that model, so that you can then prepare to send it off to the database to insert:
https://github.com/MwMaki/CS412Final_Azzawie/blob/d8eaaf82b71235f0a1908315f0c6aaabb6f843f3/CS412Final_Azzawie/CreateAd.aspx.cs#L56

Great job on your homepage!

Here, personally, I would do Session = user, this way you have access to the user data later on:
https://github.com/MwMaki/CS412Final_Azzawie/blob/d8eaaf82b71235f0a1908315f0c6aaabb6f843f3/CS412Final_Azzawie/LogIn.aspx.cs#L60

You should implement this page as it's not yet implemented (unless UserAds replaced it?):
https://github.com/MwMaki/CS412Final_Azzawie/blob/HomeWork/2021-06-16/CS412Final_Azzawie/MyAds.aspx

Same here:
https://github.com/MwMaki/CS412Final_Azzawie/blob/d8eaaf82b71235f0a1908315f0c6aaabb6f843f3/CS412Final_Azzawie/SignUp.aspx.cs#L115