ayyaruq / ffxiv-dissector Goto Github PK

therefore they are skipped in dissect_message and with the changes in #2 the following messages in the frame got discarded. Should either cut the messages before processing them in dissect_message or do some extra check in it.

Hookup Travis or alternatives with Windows/Mac/Linux support (options?) to at least build and compile with clang and gcc, and maybe msvc on pull requests and master commits. Some contributor feedback for pull requests in general could be good too.

• compile and verify on each platform with multiple compilers for PR and branch commits
• code style verification for PR
• pcap replay tests for PR and master commits

Frame timestamps don't show as time but rather strings. When coerced into timestamps, they're wrong. It looks like they're using epoch without milliseconds. This may be fixed with Wireshark 2.2.7 (currently in RC) or 2.3.0 (untested) but isn't in 2.2.6 which is the default version in OSX and Windows yet.

Verify if anything is broken and coordinate fixes if required. Only really relevant to the top level frame and message format parsing than actual messages.